FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

made todo labels consistent by badasahog · Pull Request #7113 · Rdatatable/data.table · GitHub

made todo labels consistent - #7113

Open
badasahog wants to merge 10 commits into
masterfrom
todoRename
Open

badasahog wants to merge 10 commits into
masterfrom
todoRename

Conversation

Copy link
Copy Markdown
Contributor

I think todo labels are the thing you're you're most likely to search code for, so making them all appear the same would seem pertinant.

It was very inconsistent, so I settled on todo:

codecov Bot commented Jul 1, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@c27ec26). Learn more about missing BASE report.
⚠️ Report is 222 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7113   +/-   ##
=========================================
  Coverage          ?   98.79%           
=========================================
  Files             ?       81           
  Lines             ?    15254           
  Branches          ?        0           
=========================================
  Hits              ?    15070           
  Misses            ?      184           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions Bot commented Jul 1, 2025
edited
Loading

Copy link
Copy Markdown
  • HEAD=todoRename slower P<0.001 for isoweek improved in #7144

Generated via commit 9ee598f

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 45 seconds
Installing different package versions 9 minutes and 53 seconds
Running and plotting the test cases 2 minutes and 37 seconds

Copy link
Copy Markdown
Member

Related: #678

MichaelChirico added the code-quality Issues related to improving code quality/readability label Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

@MichaelChirico this should make that work, right? or do you prefer a different syntax?

Copy link
Copy Markdown
Member

We can worry about the exact syntax later -- once we have something consistent, at least, a find-and-replace version becomes a lot easier.

That said, this PR will also sit idle for a while in the spirit of avoiding merge conflicts 🫤

Copy link
Copy Markdown
Member

Here are the unique, open, non-draft PRs touching files also touched by this PR: #6965, #6640, #6595, #6111, #5907, #5898, #5896, #5895, #5893, #5892, #5890, #5692, #5682, #5576, #5575, #5269, #5168, #5167, #4978, #4585, #4372, #4370

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality Issues related to improving code quality/readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL