FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes for `integer64` issues in `between` by aitap · Pull Request #7193 · Rdatatable/data.table · GitHub

/ data.table Public

Fixes for integer64 issues in between - #7193

Merged
MichaelChirico merged 9 commits into
masterfrom
between-int64
Jul 22, 2025
ConversationCommits (9)ChecksFiles changed
Merged

Fixes for integer64 issues in between#7193
MichaelChirico merged 9 commits into
masterfrom
between-int64

Conversation

aitap commented Jul 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #7164

  • Move the check for integer64 mismatch between x and lower/upper above the potential type conversions.
    • Optionally: fail integer64 vectors in fitsInInt32 and fitsInInt64. The additional calls to inherits() may result in a slowdown?
  • Do not auto-convert the boundaries from numeric to integer64. This might break if someone relied on between(<integer64>, <numeric fraction>, <numeric fraction>) automatically rounding to integer64. May have to check the range instead of fully checking fitsInInt64?

aitap added 5 commits July 19, 2025 20:58
tests: failing integer64 readable as small integer
380bcba
between: check for integer64 before coercion
e201bb9 
In particular, avoid calling fitsInInt32() on REALSXP vectors that could
possibly be of class 'integer64' (and therefore shouldn't be read as
doubles).
fitInInt*: disallow integer64
4e7e927 
Since the functions themselves read the vector as double* and are used
as a test whether doubles from the vector would fit in an integer, avoid
reading integer64 vectors altogether.
tests: failing blind double -> int64 conversion
e48e45c
between: convert bounds to int64 only if they fit
3a4c6b9 
Avoid auto-converting 'lower' or 'upper' to integer64 if they aren't
actually representable in int64_t.
aitap changed the title Fixes for integer64 issues Fixes for integer64 issues in between Jul 19, 2025

codecov Bot commented Jul 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (7f14f2e) to head (d2fa90f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7193   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          81       81           
  Lines       15218    15223    +5     
=======================================
+ Hits        15032    15037    +5     
  Misses        186      186

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions Bot commented Jul 19, 2025 •
edited
Loading

Copy link
Copy Markdown

No obvious timing issues in HEAD=between-int64

Generated via commit d2fa90f

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 53 seconds
Installing different package versions 39 seconds
Running and plotting the test cases 2 minutes and 34 seconds

MichaelChirico reviewed Jul 20, 2025
View reviewed changes
Comment thread src/between.c Outdated
MichaelChirico reviewed Jul 20, 2025
View reviewed changes
Comment thread src/between.c Outdated
MichaelChirico reviewed Jul 20, 2025
View reviewed changes
Comment thread src/utils.c
Apply suggestions from code review
bce0c05 
Unify the translatable strings.

Co-authored-by: Michael Chirico <chiricom@google.com>
MichaelChirico reviewed Jul 22, 2025
View reviewed changes
Comment thread src/between.c Outdated
aitap and others added 2 commits July 22, 2025 20:12
Fix tests for error messages
d93f98d
Make the error messages more symmetric.
53bae8b 
Co-authored-by: Michael Chirico <chiricom@google.com>
MichaelChirico approved these changes Jul 22, 2025
View reviewed changes

MichaelChirico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

MichaelChirico merged commit 52b1ceb into master Jul 22, 2025
MichaelChirico deleted the between-int64 branch July 22, 2025 17:26

aitap commented Jul 22, 2025

Copy link
Copy Markdown
Member Author

Does the change in behaviour regarding integer64 boundaries need a news entry? I don't see it documented anywhere.

MichaelChirico commented Jul 22, 2025

Copy link
Copy Markdown
Member

Ah, yes, that's a bug fix based on the issue you filed.

aitap added a commit that referenced this pull request Jul 24, 2025
NEWS entry for #7193
f0839fe
aitap mentioned this pull request Jul 24, 2025
Merged
MichaelChirico pushed a commit that referenced this pull request Jul 24, 2025
NEWS entry for #7193 (#7208)
63339e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MichaelChirico MichaelChirico approved these changes
HughParsonage Awaiting requested review from HughParsonage HughParsonage is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

between() gives wrong answers for some integer64 inputs

2 participants

Back | FazBrowse Home | New Git URL