FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add requires_utf8 argument to tests by ben-schwen · Pull Request #7388 · Rdatatable/data.table · GitHub

add requires_utf8 argument to tests - #7388

Merged
ben-schwen merged 25 commits into
masterfrom
tests_requires_utf8
Jan 11, 2026
Merged

ben-schwen merged 25 commits into
masterfrom
tests_requires_utf8

Conversation

ben-schwen commented Oct 25, 2025
edited
Loading

Copy link
Copy Markdown
Member

Closes #7336
Closes #1343
Closes #7333

codecov Bot commented Oct 25, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (f3b166b) to head (1d18cff).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7388   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          87       87           
  Lines       16754    16795   +41     
=======================================
+ Hits        16591    16632   +41     
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions Bot commented Oct 25, 2025
edited
Loading

Copy link
Copy Markdown
  • HEAD=tests_requires_utf8 slower P<0.001 for setDT improved in #5427
  • HEAD=tests_requires_utf8 slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
  • HEAD=tests_requires_utf8 slower P<0.001 for memrecycle regression fixed in #5463

Generated via commit 1d18cff

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 3 seconds
Installing different package versions 45 seconds
Running and plotting the test cases 4 minutes and 28 seconds

aitap commented Oct 25, 2025

Copy link
Copy Markdown
Member

Sorry if I'm late to note this, but wouldn't a more reliable test for this be the same thing as we currently use for ñ in test 2266? A test may require some symbols (ñ, ü, ん) to be representable in the native encoding. The symbols may be represented using Unicode escapes (\uXXXX) as they currently do. If !identical(foo, enc2native(foo)), then the test must be skipped.

Copy link
Copy Markdown
Member Author

The symbols may be represented using Unicode escapes (\uXXXX) as they currently do. If !identical(foo, enc2native(foo)), then the test must be skipped.

Good point. I have integrated this for the utf8_check.

ben-schwen requested review from MichaelChirico and removed request for MichaelChirico December 28, 2025 15:03
Comment thread inst/tests/tests.Rraw Outdated
Comment thread inst/tests/tests.Rraw Outdated
Comment thread inst/tests/tests.Rraw Outdated
Comment thread inst/tests/tests.Rraw Outdated
Comment thread inst/tests/tests.Rraw Outdated
Comment thread NEWS.md Outdated
Comment thread inst/tests/tests.Rraw Outdated
Comment thread R/test.data.table.R Outdated

MichaelChirico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

2 more minor points, feel free to merge. Thanks!

ben-schwen merged commit 0ebe04b into master Jan 11, 2026
12 checks passed
ben-schwen deleted the tests_requires_utf8 branch January 11, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add argument like 'requires_utf8' to test() Escape UTF-8 dependent tests Finish DtNonAsciiTests package and submit to CRAN

4 participants


Back | FazBrowse Home | New Git URL