FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix frollapply to handle n > len case by jangorecki · Pull Request #7650 · Rdatatable/data.table · GitHub

/ data.table Public

Fix frollapply to handle n > len case - #7650

Merged
ben-schwen merged 6 commits into
masterfrom
frollapply_n_lenx
Mar 15, 2026
ConversationCommits (6)ChecksFiles changed
Merged

Fix frollapply to handle n > len case#7650
ben-schwen merged 6 commits into
masterfrom
frollapply_n_lenx

Conversation

jangorecki commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

closes #7646

jangorecki added this to the 1.18.4 milestone Feb 26, 2026
jangorecki linked an issue Feb 26, 2026 that may be closed by this pull request
frollapply can produce output longer than the input when the window-length is also longer than the input #7646
Closed

codecov Bot commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (d86e1f5) to head (8d4e84d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7650   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          87       87           
  Lines       17029    17031    +2     
=======================================
+ Hits        16866    16868    +2     
  Misses        163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions Bot commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
  • HEAD=frollapply_n_lenx stopped early for fread(select=list(Date='date')) improved in #6107

Generated via commit 301409b

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 38 seconds
Installing different package versions 21 seconds
Running and plotting the test cases 3 minutes and 29 seconds

MichaelChirico reviewed Feb 26, 2026
View reviewed changes
Comment thread NEWS.md Outdated
MichaelChirico approved these changes Feb 26, 2026
View reviewed changes

MichaelChirico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does it warrant a patch release?

Update NEWS.md
301409b 
Co-authored-by: Michael Chirico <chiricom@google.com>

jangorecki commented Feb 28, 2026

Copy link
Copy Markdown
Member Author

No, function is said to be experimental so I think we can postpone 1.18.4 till CRAN will require us to patch something. Then this change should be included. Unless there will be many reports about it...

ben-schwen reviewed Mar 12, 2026
View reviewed changes
Comment thread R/frollapply.R Outdated
jangorecki and others added 2 commits March 14, 2026 11:05
Apply suggestion from @ben-schwen
ec4ac24 
Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
Merge branch 'master' into frollapply_n_lenx
8d4e84d
ben-schwen merged commit 7db13b9 into master Mar 15, 2026
13 of 14 checks passed
ben-schwen deleted the frollapply_n_lenx branch March 15, 2026 13:26
aitap pushed a commit that referenced this pull request May 4, 2026
Fix frollapply to handle n > len case (#7650)
846cbf6 
* Fix frollapply to handle n > len case

* unit test for bugfix

* news entry

* Update NEWS.md

Co-authored-by: Michael Chirico <chiricom@google.com>

* Apply suggestion from @ben-schwen

Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>

---------

Co-authored-by: Michael Chirico <chiricom@google.com>
Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MichaelChirico MichaelChirico approved these changes
ben-schwen ben-schwen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.18.4

Development

Successfully merging this pull request may close these issues.

frollapply can produce output longer than the input when the window-length is also longer than the input

3 participants

Back | FazBrowse Home | New Git URL