Improve multiple task handling (Task.all/any/some) in case of empty tasks-argument - #60
Merged
inamiy merged 1 commit intoMar 19, 2016
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…mpty `tasks`-argument
inamiy
added a commit
that referenced
this pull request
Mar 19, 2016
…y-case Improve multiple task handling (`Task.all`/`any`/`some`) in case of empty `tasks`-argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement for multiple task handling (Task.all/any/some) to also work for empty tasks case as discussed in #59.
For compatibility, Task.any is using precondition instead to warn users not to pass empty array from the beginning.
(For better typing, we need different signature e.g. public class func any(tasks: [Task]) -> Task<BulkProgress, Value?, Error>)