FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Begin the steps to release 1.0.15 by abersnaze · Pull Request #3456 · ReactiveX/RxJava · GitHub

Begin the steps to release 1.0.15 - #3456

Merged
abersnaze merged 1 commit into
ReactiveX:1.xfrom
abersnaze:1.0.15
Oct 30, 2015
Merged

Begin the steps to release 1.0.15#3456
abersnaze merged 1 commit into
ReactiveX:1.xfrom
abersnaze:1.0.15

Conversation

Copy link
Copy Markdown
Collaborator

Can get two more 👍 from the committers.

Copy link
Copy Markdown
Member

It would be great to get these PRs in as well:

#3458 : CompositeSubscription javadoc change
#3455 : [Bug] OnErrorFailedException propagation fix
#3454 : [Bug] Fix bounded replay() request behavior
#3438 : Better null tolerance, although this may need rebase due to #3455

Comment thread CHANGES.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This line isn't needed since it's not actually affecting code or functionality.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removing.

Copy link
Copy Markdown
Member

👍 for getting this release out. I provided some non-essential feedback on suggestions for things I would change or not include in the release notes based on how I've done it in thus far. With or without those changes (except the one I thing has a misleading title), I'm good with the release going out.

Copy link
Copy Markdown
Member

Agreed that we should get the items @akarnokd mentioned into this release. Some are already merged and just need to be put in the release notes. I've looked at the others and think they are all okay for merging before release.

Copy link
Copy Markdown
Member

Great, these are already merged in:

#3458 : CompositeSubscription javadoc change
#3455 : [Bug] OnErrorFailedException propagation fix
#3438 : Better null tolerance, although this may need rebase due to #3455

I feel this one can be merged but would like someone to review it in more detail:

#3454 : [Bug] Fix bounded replay() request behavior

I don't know how urgent are these as they were reported by Netflix:

#3428 [bug] GroupBy request fix
#3169 Merge support for horizontally unbounded mode

Copy link
Copy Markdown

👍

Copy link
Copy Markdown

I think I'd prefer to cut a release of 1.0.15 asap and get the changes like #3454, #3428, and #3169 in a subsequent 1.0.16 release.

Can I get a +1 to initiate the 1.0.15 release?

Copy link
Copy Markdown
Contributor

👍 (not a "collaborator" though). Let's finally release 1.0.15, a lot of good stuff for Rx users!

@abersnaze can you please squash commits in this PR?

Copy link
Copy Markdown
Member

+1 for release of what is already merged.

Copy link
Copy Markdown
Member

👍

Copy link
Copy Markdown
Collaborator Author

I was getting lazy. thanks @artem-zinnatullin.

abersnaze added a commit that referenced this pull request Oct 30, 2015
Begin the steps to release 1.0.15
abersnaze merged commit 51527b7 into ReactiveX:1.x Oct 30, 2015

Copy link
Copy Markdown
Member

👍

abersnaze deleted the 1.0.15 branch November 4, 2015 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL