FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Observable.take scheduler annotation by evgenyponomarev · Pull Request #8289 · ReactiveX/RxJava · GitHub

Fix Observable.take scheduler annotation - #8289

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
evgenyponomarev:codex/fix-observable-take-scheduler-support
Aug 19, 2026
Merged

Fix Observable.take scheduler annotation#8289
akarnokd merged 1 commit into
ReactiveX:4.xfrom
evgenyponomarev:codex/fix-observable-take-scheduler-support

Conversation

Copy link
Copy Markdown
Contributor

Summary

  • change the scheduler support for Observable.take(long, TimeUnit) from NONE to COMPUTATION
  • align the annotation with the default timer(time, unit) implementation, its Javadoc, and the equivalent Flowable overload

Fixes #8288

Validation

  • ./gradlew test --tests "io.reactivex.rxjava4.validators.CheckBaseTypeAnnotationsTest" --tests "io.reactivex.rxjava4.validators.CheckJavadocForAnnotationsTest"
  • ./gradlew test --tests "io.reactivex.rxjava4.validators.*" --stacktrace --no-daemon
  • ./gradlew build --stacktrace
  • ./gradlew javadoc --stacktrace

AI disclosure

This contribution was made with OpenAI Codex assistance. Codex inspected the current 4.x implementation and contribution policy, applied the one-line annotation correction, and ran the validation listed above. The reasoning was that this overload delegates to the default computation-scheduler timer, its Javadoc already documents computation scheduling, and the equivalent Flowable overload already uses SchedulerSupport.COMPUTATION.

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.763 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/main/java/io/reactivex/rxjava4/core/Observable.java: 4.763

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.61%. Comparing base (4e481d5) to head (3f0e302).

Additional details and impacted files
@@            Coverage Diff            @@
##                4.x    #8289   +/-   ##
=========================================
  Coverage     98.60%   98.61%           
+ Complexity     7150     7149    -1     
=========================================
  Files           824      824           
  Lines         50791    50791           
  Branches       6911     6911           
=========================================
+ Hits          50084    50088    +4     
+ Misses          482      480    -2     
+ Partials        225      223    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

akarnokd merged commit 2234caf into ReactiveX:4.x Aug 19, 2026
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading SchedulerSupport for function Observable.take

2 participants


Back | FazBrowse Home | New Git URL