Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0aeb03e6-f65a-4fb0-ad09-afd1ca7a0f50

Reviewing files that changed from the base of the PR and between 1245433 and 73baf55.

• src/ui/reducers/__tests__/stateGroups.spec.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Use TypeScript for all new code unless explicitly told otherwise.
Use Fuselage components for all UI work; only create custom components when Fuselage does not provide what is needed.
Import UI components from @rocket.chat/fuselage.
Check Theme.d.ts for valid color tokens before using Fuselage theme colors.
Use optional chaining with fallbacks for platform-specific APIs, especially Linux-only process APIs like process.getuid(), process.getgid(), process.geteuid(), and process.getegid().
Only mock platform-specific APIs when defensive coding is not possible.
Use TypeScript strict mode.
Use React functional components with hooks.
Redux actions must follow the Flux Standard Action (FSA) pattern.
Use camelCase for file names and PascalCase for components.

**/*.{ts,tsx}: Use TypeScript for new code unless explicitly told otherwise.
Use Fuselage components from @rocket.chat/fuselage for UI work unless the design requires something Fuselage does not provide.
Check Theme.d.ts for valid color tokens before using Fuselage colors.
Verify library props, APIs, and tokens against official docs or local .d.ts files instead of assuming.
Use React functional components with hooks.
Redux actions follow FSA shape.
Use camelCase for file names and PascalCase for components.
Prefer clear names over unnecessary comments.
Prefer editing existing files over creating new abstractions unless the new abstraction removes real complexity or matches an existing pattern.

Files:

• src/ui/reducers/__tests__/stateGroups.spec.ts

📄 CodeRabbit inference engine (CLAUDE.md)

Use *.spec.ts for renderer process tests.

Files:

• src/ui/reducers/__tests__/stateGroups.spec.ts

📄 CodeRabbit inference engine (AGENTS.md)

Renderer specs use *.spec.ts / *.spec.tsx.

Files:

• src/ui/reducers/__tests__/stateGroups.spec.ts

Learnt from: nazabucciarelli
Repo: RocketChat/Rocket.Chat.Electron PR: 3329
File: src/ui/reducers/e2ePdfPreviewSizeLimit.ts:14-16
Timestamp: 2026-05-19T20:49:24.859Z
Learning: In Rocket.Chat.Electron’s reducer files under src/ui/reducers/, reducers should not re-implement validation for action payloads. Assume the caller (UI component or dispatch site) has already validated the action payload and type/shape; reducers should trust the payload and update state directly. If validation is needed, add it at the dispatch site/caller rather than inside the reducer.

Applied to files:

• src/ui/reducers/__tests__/stateGroups.spec.ts

Learnt from: nazabucciarelli
Repo: RocketChat/Rocket.Chat.Electron PR: 3329
File: src/ui/reducers/e2ePdfPreviewSizeLimit.ts:14-16
Timestamp: 2026-05-19T20:49:24.859Z
Learning: In the Rocket.Chat.Electron UI reducers under src/ui/reducers/, do not add/repeat input validation for action payloads inside reducers. Follow the existing codebase pattern: validate the action payload in the caller (e.g., the UI component or dispatch site) before dispatching. Reducers should trust the incoming payload and apply it directly to state. If adding/updating a reducer, ensure the corresponding caller performs the necessary validation (e.g., check numeric constraints like !isNaN(value) && value > 0 before dispatching the action).

Applied to files:

• src/ui/reducers/__tests__/stateGroups.spec.ts

src/ui/reducers/__tests__/stateGroups.spec.ts (1)

90-90: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Update the test description to remove the stale "downloads back button" reference.

The it title at line 90 still says "handles side-bar remove, downloads back button, and servers loaded" but the DOWNLOADS_BACK_BUTTON_CLICKED assertion was removed. The description no longer matches the test body.

♻️ Proposed fix

-  it('handles side-bar remove, downloads back button, and servers loaded', () => {
+  it('handles side-bar remove, downloads button, and servers loaded', () => {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  it('handles side-bar remove, downloads button, and servers loaded', () => {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ui/reducers/__tests__/stateGroups.spec.ts` at line 90, The test title in
stateGroups.spec.ts is stale because it still mentions the removed
DOWNLOADS_BACK_BUTTON_CLICKED case. Update the it description for the
stateGroups reducer test so it matches the remaining assertions around side-bar
remove and servers loaded, using the existing test name near the stateGroups
spec block to locate it.

Walkthrough

WorkspaceTab now types its drag-over handler parameter as DragEvent. One assertion was removed from the stateGroups reducer test for the DOWNLOADS_BACK_BUTTON_CLICKED action.

Changes

WorkspaceTab Type Fix

Reducer Test Update

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• RocketChat/Rocket.Chat.Electron#3394: Also touches WorkspaceTab.tsx and stateGroups.spec.ts, with related navigation/downloads-view test expectations.

Suggested labels: type: chore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands.