feat(ui): unify Windows/Linux shell chrome and menu bar by jeanfbrito · Pull Request #3450 · RocketChat/Rocket.Chat.Electron · GitHub

Summary

Menu bar (Windows + Linux): hidden by default; press Alt to show temporarily; Settings → General → Menu bar (or View → Menu bar / Ctrl+Shift+M) pins it always visible. One-shot config revision migrates existing installs that stored true while the bar was forced hidden on Windows / always-on on Linux.
Linux client decorations: same shell chrome as Windows — no DE title bar; min/max/close embedded in the tab strip / TopBar; meatball + update/downloads layout aligned with win32.
Linux outer corners: soft 10px radius via transparent frame + CSS (skipped when maximized). Windows keeps DWM rounding.
Removed obsolete “menu bar only toggles in sidebar / can’t use tabs without menu bar” coupling now that the meatball menu is always available.

Test plan

Linux (Ubuntu/Manjaro/openSUSE): no native DE title bar; window controls work (min/max/close); drag the strip to move the window
Linux: outer corners slightly rounded; square when maximized
Linux/Windows: menu bar off by default; Alt reveals it; Settings toggle pins it; choice survives restart
macOS: unchanged (system menu bar + traffic lights)
All navigation layouts (tabs / sidebar / hidden) still show meatball + downloads/update where expected
Unit: Shell/index.spec.tsx, menu bar data/PersistableValues/reducer specs

Verified on lab VMs: Ubuntu 22.04 (GNOME X11), Manjaro (KDE Wayland/XWayland), openSUSE (KDE X11).

Summary by CodeRabbit

New Features
- Menu bar visibility now defaults to enabled on macOS and disabled on Windows/Linux.
- Windows and Linux users can temporarily show the menu bar with Alt.
- Menu bar settings are available across supported desktop platforms.
- Linux now includes Windows-style client-side window controls and rounded window chrome.
Improvements
- Workspace layout options remain available regardless of menu bar visibility.
- Updated menu bar and navigation descriptions clarify platform behavior.
- Windows/Linux window controls and menus now provide more consistent behavior.

Hide the native menu bar by default on Windows and Linux (Alt reveals it; Settings or View → Menu bar pins it always-on). Give Linux the same client window chrome as Windows — embedded min/max/close, no DE title bar — with a soft outer corner radius. Drop the obsolete menu-bar/layout safety coupling now that the meatball menu is always available.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f790183f-c810-4c14-bcb3-8de9c89c5f97

📥 Commits

Reviewing files that changed from the base of the PR and between 1fb8974 and a76742b.

📒 Files selected for processing (1)

src/ui/components/Shell/index.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

src/ui/components/Shell/index.tsx

📜 Recent review details ⏰ Context from checks skipped due to timeout. (3)

GitHub Check: check (windows-latest)
GitHub Check: check (ubuntu-latest)
GitHub Check: Analyze (javascript)

Walkthrough

The PR changes menu-bar defaults and persistence across platforms, removes menu-bar dependencies from workspace navigation, adds non-macOS menu controls, and updates Linux windows to use client-side chrome with rounded rendering and window controls.

Changes

Menu bar and client chrome

Layer / File(s)	Summary
Menu-bar persistence migration src/app/PersistableValues.ts, src/app/main/persistence.ts, src/app/main/data.ts, src/app/main/data.spec.ts, src/app/__tests__/PersistableValues.spec.ts	Persisted values now include menuBarDefaultRevision. Version 4.16.2 preserves macOS settings and disables the menu bar on Windows/Linux. Persistence tests cover stale and current revisions.
Platform menu-bar behavior and settings src/ui/reducers/isMenuBarEnabled., src/ui/main/menuBar.ts, src/ui/components/TabBar/MeatballMenuButton., src/ui/components/SettingsView/..., src/i18n/en.i18n.json, README.md, docs/silent-installation.md	Windows and Linux default to a hidden menu bar. Non-macOS menu-bar controls remain available, while workspace navigation stays enabled. Alt-key handling remains in the native menu on Windows/Linux and uses the application handler on macOS.
Linux client chrome src/ui/components/Shell/*, src/ui/components/Shell/styles.tsx, src/ui/main/rootWindow.ts	Linux root windows use hidden title bars, transparent backgrounds, shadows, rounded corners, and client-side window controls. Shell tests cover tabs, sidebar, and hidden layouts.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant Persistence
  participant MenuBar
  App->>Persistence: Read menuBarDefaultRevision
  Persistence-->>App: Return persisted revision
  App->>Persistence: Store current revision when stale
  App->>MenuBar: Apply platform-specific visibility
  MenuBar-->>App: Keep menu attached and update visibility

Possibly related PRs

RocketChat/Rocket.Chat.Electron#3449: Shares src/ui/components/Shell/index.tsx changes involving Linux layout rendering and TopBar behavior.

Suggested labels: type: feature

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the primary changes to Windows and Linux shell chrome and menu bar behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Actionable comments posted: 3

🧹 Nitpick comments (1)

src/ui/components/Shell/index.tsx (1)
92-95: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Replace the hard-coded Linux edge shadow with a theme-aware token.

At src/ui/components/Shell/index.tsx:95, '0 0 0 1px rgba(0, 0, 0, 0.14)' makes the rounded Linux silhouette ignore dark-mode theme changes. Use the active theme color/token instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ui/components/Shell/index.tsx` around lines 92 - 95, Update the
non-expanded boxShadow value in the Shell component to use the active theme’s
color or shadow token instead of the hard-coded rgba value, while preserving the
undefined behavior when isWindowExpanded is true.
Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 226: Correct the isMenuBarEnabled documentation row in README.md so true
indicates the menu bar remains always visible on Windows/Linux, while false
enables auto-hide with Alt showing it temporarily; retain the macOS caveat.

In `@src/app/main/data.ts`:
- Around line 11-18: Resolve the static-check formatting issues: in
src/app/main/data.ts (lines 11-18), move the ../PersistableValues import before
../actions; format the getPersistedMeta call at lines 177-180 per the formatter.
Apply the same import ordering change in src/app/main/data.spec.ts (lines 3-9)
and format the mockReturnValue call at line 176 according to formatter output.

In `@src/ui/main/rootWindow.ts`:
- Around line 80-86: Update the Linux branch of the Shell Tabs rendering around
TabBar to provide a window drag region, either by rendering WindowDragBar
alongside TabBar or by applying the equivalent draggable styling to TabBar.
Preserve the existing macOS-specific handling and ensure Linux windows remain
movable with the hidden title bar.

---

Nitpick comments:
In `@src/ui/components/Shell/index.tsx`:
- Around line 92-95: Update the non-expanded boxShadow value in the Shell
component to use the active theme’s color or shadow token instead of the
hard-coded rgba value, while preserving the undefined behavior when
isWindowExpanded is true.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e1615aec-ac7d-4e44-a1e8-c00029dbb079

📥 Commits

Reviewing files that changed from the base of the PR and between 3207b48 and ede5d7d.

📒 Files selected for processing (21)

README.md
docs/silent-installation.md
src/app/PersistableValues.ts
src/app/__tests__/PersistableValues.spec.ts
src/app/main/data.spec.ts
src/app/main/data.ts
src/app/main/persistence.ts
src/i18n/en.i18n.json
src/ui/components/SettingsView/GeneralTab.tsx
src/ui/components/SettingsView/features/MenuBar.tsx
src/ui/components/SettingsView/features/NavigationLayout.spec.tsx
src/ui/components/SettingsView/features/NavigationLayout.tsx
src/ui/components/Shell/index.spec.tsx
src/ui/components/Shell/index.tsx
src/ui/components/Shell/styles.tsx
src/ui/components/TabBar/MeatballMenuButton.spec.tsx
src/ui/components/TabBar/MeatballMenuButton.tsx
src/ui/main/menuBar.ts
src/ui/main/rootWindow.ts
src/ui/reducers/isMenuBarEnabled.spec.ts
src/ui/reducers/isMenuBarEnabled.ts

📜 Review details ⏰ Context from checks skipped due to timeout. (2)

GitHub Check: check (windows-latest)
GitHub Check: check (macos-latest)

🧰 Additional context used 📓 Path-based instructions (7) **/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use TypeScript for new code unless explicitly told otherwise.
Use Fuselage components from @rocket.chat/fuselage for UI work unless the design requires something Fuselage does not provide.
Check Theme.d.ts for valid color tokens before using Fuselage colors.
Verify library props, APIs, and tokens against official docs or local .d.ts files instead of assuming.
Use React functional components with hooks.
Redux actions follow FSA shape.
Use camelCase for file names and PascalCase for components.
Prefer clear names over unnecessary comments.
Prefer editing existing files over creating new abstractions unless the new abstraction removes real complexity or matches an existing pattern.

**/*.{ts,tsx}: Use TypeScript for all new code unless explicitly told otherwise.
Use Fuselage components for all UI work; create custom components only when Fuselage lacks the required functionality.
Import Fuselage components from @rocket.chat/fuselage.
Use only valid color tokens documented by Theme.d.ts.
Use optional chaining with fallbacks for platform-specific APIs, especially Linux-only process APIs such as process.getuid(), getgid(), geteuid(), and getegid().
Use TypeScript strict mode.
Redux actions must follow the Flux Standard Action pattern.
Use camelCase for file names and PascalCase for component names.
Avoid unnecessary comments; prefer self-documenting code through clear naming.
Do not commit or push without explicit user permission.
Verify library APIs, props, tokens, and types against official documentation and .d.ts files instead of assuming they are valid.

Files:

src/ui/components/SettingsView/GeneralTab.tsx
src/ui/reducers/isMenuBarEnabled.ts
src/app/__tests__/PersistableValues.spec.ts
src/ui/components/SettingsView/features/NavigationLayout.tsx
src/ui/reducers/isMenuBarEnabled.spec.ts
src/ui/components/TabBar/MeatballMenuButton.tsx
src/ui/main/rootWindow.ts
src/app/main/persistence.ts
src/ui/components/SettingsView/features/MenuBar.tsx
src/app/main/data.spec.ts
src/ui/components/Shell/styles.tsx
src/ui/components/Shell/index.tsx
src/ui/components/TabBar/MeatballMenuButton.spec.tsx
src/app/PersistableValues.ts
src/app/main/data.ts
src/ui/components/Shell/index.spec.tsx
src/ui/main/menuBar.ts
src/ui/components/SettingsView/features/NavigationLayout.spec.tsx

**/*.{tsx,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use React functional components with hooks.

Files:

src/ui/components/SettingsView/GeneralTab.tsx
src/ui/components/SettingsView/features/NavigationLayout.tsx
src/ui/components/TabBar/MeatballMenuButton.tsx
src/ui/components/SettingsView/features/MenuBar.tsx
src/ui/components/Shell/styles.tsx
src/ui/components/Shell/index.tsx
src/ui/components/TabBar/MeatballMenuButton.spec.tsx
src/ui/components/Shell/index.spec.tsx
src/ui/components/SettingsView/features/NavigationLayout.spec.tsx

**/*.spec.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Renderer specs use *.spec.ts / *.spec.tsx.

Files:

src/app/__tests__/PersistableValues.spec.ts
src/ui/reducers/isMenuBarEnabled.spec.ts
src/app/main/data.spec.ts
src/ui/components/TabBar/MeatballMenuButton.spec.tsx
src/ui/components/Shell/index.spec.tsx
src/ui/components/SettingsView/features/NavigationLayout.spec.tsx

src/*/*/*.spec.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Renderer specs must live in a Jest-matched nested path, such as src/<module>/<subdir>/*.spec.ts(x); flat src/<module>/*.spec.ts files are not discovered by the current testMatch.

Files:

src/app/__tests__/PersistableValues.spec.ts
src/ui/reducers/isMenuBarEnabled.spec.ts
src/app/main/data.spec.ts

**/*.spec.ts

📄 CodeRabbit inference engine (CLAUDE.md)

Use *.spec.ts for renderer process tests.

Files:

src/app/__tests__/PersistableValues.spec.ts
src/ui/reducers/isMenuBarEnabled.spec.ts
src/app/main/data.spec.ts

src/**/*.{spec.ts,spec.tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Renderer test files should be placed in nested module paths such as src/<module>/<subdir>/*.spec.ts(x) so Jest discovers them.

Files:

src/app/__tests__/PersistableValues.spec.ts
src/ui/reducers/isMenuBarEnabled.spec.ts
src/app/main/data.spec.ts
src/ui/components/TabBar/MeatballMenuButton.spec.tsx
src/ui/components/Shell/index.spec.tsx
src/ui/components/SettingsView/features/NavigationLayout.spec.tsx

**/*.{md,mdx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{md,mdx}: Avoid subjective descriptors and use measurable descriptions.
Never invent metrics; use only numbers from actual logs, error messages, or documented sources.
PR descriptions should use straightforward language and focus on what changed and why.

Files:

docs/silent-installation.md
README.md

🧠 Learnings (5) 📚 Learning: 2026-05-19T20:49:24.859Z

Learnt from: nazabucciarelli
Repo: RocketChat/Rocket.Chat.Electron PR: 3329
File: src/ui/reducers/e2ePdfPreviewSizeLimit.ts:14-16
Timestamp: 2026-05-19T20:49:24.859Z
Learning: In Rocket.Chat.Electron’s reducer files under src/ui/reducers/, reducers should not re-implement validation for action payloads. Assume the caller (UI component or dispatch site) has already validated the action payload and type/shape; reducers should trust the payload and update state directly. If validation is needed, add it at the dispatch site/caller rather than inside the reducer.

Applied to files:

src/ui/reducers/isMenuBarEnabled.ts
src/ui/reducers/isMenuBarEnabled.spec.ts

📚 Learning: 2026-05-19T20:49:24.859Z

Learnt from: nazabucciarelli
Repo: RocketChat/Rocket.Chat.Electron PR: 3329
File: src/ui/reducers/e2ePdfPreviewSizeLimit.ts:14-16
Timestamp: 2026-05-19T20:49:24.859Z
Learning: In the Rocket.Chat.Electron UI reducers under src/ui/reducers/, do not add/repeat input validation for action payloads inside reducers. Follow the existing codebase pattern: validate the action payload in the caller (e.g., the UI component or dispatch site) before dispatching. Reducers should trust the incoming payload and apply it directly to state. If adding/updating a reducer, ensure the corresponding caller performs the necessary validation (e.g., check numeric constraints like !isNaN(value) && value > 0 before dispatching the action).

Applied to files:

src/ui/reducers/isMenuBarEnabled.ts
src/ui/reducers/isMenuBarEnabled.spec.ts

📚 Learning: 2026-06-26T18:14:11.817Z

Learnt from: jeanfbrito
Repo: RocketChat/Rocket.Chat.Electron PR: 3358
File: src/ui/components/SettingsView/features/E2ePdfPreviewSizeLimit.tsx:47-55
Timestamp: 2026-06-26T18:14:11.817Z
Learning: In the Rocket.Chat Electron App SettingsView features under `src/ui/components/SettingsView/features/`, treat full-width selects/inputs (including full-width numeric inputs) as intentional for the stacked label/description layout. Per the UXDQA Figma spec (and macOS 1:1 verification), reviews should not flag these as layout regressions as long as they match the expected form-column stretching behavior.

Applied to files:

src/ui/components/SettingsView/features/NavigationLayout.tsx
src/ui/components/SettingsView/features/MenuBar.tsx
src/ui/components/SettingsView/features/NavigationLayout.spec.tsx

📚 Learning: 2026-06-26T18:14:13.838Z

Learnt from: jeanfbrito
Repo: RocketChat/Rocket.Chat.Electron PR: 3358
File: src/ui/components/SettingsView/features/ToggleField.tsx:1-8
Timestamp: 2026-06-26T18:14:13.838Z
Learning: In Rocket.Chat Electron App settings field UIs that use the Fuselage three-tier pattern, keep the `FieldLabel` / `FieldDescription` / `FieldHint` structure separate. Use `FieldDescription` for the regular secondary body text, and reserve `FieldHint` for the smaller, dimmer subline content (e.g., restart caveats). Do not collapse `FieldDescription` and `FieldHint` into a single hint tier, as this violates the intended UXDQA spec.

Applied to files:

src/ui/components/SettingsView/features/NavigationLayout.tsx
src/ui/components/SettingsView/features/MenuBar.tsx
src/ui/components/SettingsView/features/NavigationLayout.spec.tsx

📚 Learning: 2026-06-26T18:14:15.295Z

Learnt from: jeanfbrito
Repo: RocketChat/Rocket.Chat.Electron PR: 3358
File: src/i18n/it-IT.i18n.json:39-42
Timestamp: 2026-06-26T18:14:15.295Z
Learning: In the i18n JSON files, the translation key `minimizeOnClose.disabledHint` is intentionally displayed when `isTrayIconEnabled` is true and the minimize-on-close toggle is disabled. The hint text should therefore instruct the user to disable the tray icon to make the setting available. During reviews, don’t “correct” this translation for seeming mismatches with the toggle state—first confirm it matches the component’s intended behavior; only update the wording if the underlying product logic/UX requirement changes.

Applied to files:

src/i18n/en.i18n.json

🪛 GitHub Check: check (ubuntu-latest) src/app/main/data.spec.ts

[failure] 3-3:
../PersistableValues import should occur before import of ../actions

[failure] 176-176:
Replace MENU_BAR_DEFAULT_REVISION with ⏎········MENU_BAR_DEFAULT_REVISION⏎······

src/app/main/data.ts

[failure] 11-11:
../PersistableValues import should occur before import of ../actions

[failure] 177-177:
Replace ⏎····'menuBarDefaultRevision',⏎····0⏎·· with 'menuBarDefaultRevision',·0

🔇 Additional comments (16)

src/app/PersistableValues.ts (1)

129-145: LGTM!

Also applies to: 265-280

src/app/main/persistence.ts (1)

31-44: LGTM!

src/app/main/data.ts (1)

181-188: LGTM!

src/app/main/data.spec.ts (1)

30-32: LGTM!

Also applies to: 61-61, 84-130, 143-168, 170-175, 177-191

src/app/__tests__/PersistableValues.spec.ts (1)

341-393: LGTM!

src/ui/components/SettingsView/features/NavigationLayout.spec.tsx (1)

14-14: LGTM!

Also applies to: 90-102

src/i18n/en.i18n.json (1)

298-298: LGTM!

Also applies to: 310-310

docs/silent-installation.md (1)

527-527: LGTM!

src/ui/reducers/isMenuBarEnabled.ts (1)

15-21: LGTM!

src/ui/reducers/isMenuBarEnabled.spec.ts (1)

10-13: LGTM!

src/ui/main/menuBar.ts (1)

443-449: LGTM!

Also applies to: 471-476, 490-498, 512-520, 1269-1282

src/ui/components/TabBar/MeatballMenuButton.tsx (1)

36-42: LGTM!

src/ui/components/TabBar/MeatballMenuButton.spec.tsx (1)

58-137: LGTM!

src/ui/components/SettingsView/GeneralTab.tsx (1)

34-34: LGTM!

src/ui/components/SettingsView/features/MenuBar.tsx (1)

35-43: LGTM!

src/ui/components/SettingsView/features/NavigationLayout.tsx (1)

49-87: LGTM!

Use an inset hairline and clamp html/body/#root overflow so the outer corner radius no longer extends the document and shows a bottom scrollbar.

Correct isMenuBarEnabled true/false wording in README and silent-install docs, and fix import order/formatting in data load helpers so CI lint passes.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/ui/components/Shell/index.tsx`:
- Line 99: Replace the hardcoded rgba color in the Shell component’s inset
box-shadow with a valid Fuselage color token or theme variable, preserving the
existing hairline styling while allowing it to adapt to the active theme.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2eee97b5-50d7-457d-bda3-024966db0a6b

📥 Commits

Reviewing files that changed from the base of the PR and between ede5d7d and 4b1795f.

📒 Files selected for processing (2)

src/ui/components/Shell/index.tsx
src/ui/components/Shell/styles.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

src/ui/components/Shell/styles.tsx

📜 Review details ⏰ Context from checks skipped due to timeout. (3)

GitHub Check: check (ubuntu-latest)
GitHub Check: check (windows-latest)
GitHub Check: check (macos-latest)

🧰 Additional context used 📓 Path-based instructions (2) **/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use TypeScript for new code unless explicitly told otherwise.
Use Fuselage components from @rocket.chat/fuselage for UI work unless the design requires something Fuselage does not provide.
Check Theme.d.ts for valid color tokens before using Fuselage colors.
Verify library props, APIs, and tokens against official docs or local .d.ts files instead of assuming.
Use React functional components with hooks.
Redux actions follow FSA shape.
Use camelCase for file names and PascalCase for components.
Prefer clear names over unnecessary comments.
Prefer editing existing files over creating new abstractions unless the new abstraction removes real complexity or matches an existing pattern.

**/*.{ts,tsx}: Use TypeScript for all new code unless explicitly told otherwise.
Use Fuselage components for all UI work; create custom components only when Fuselage lacks the required functionality.
Import Fuselage components from @rocket.chat/fuselage.
Use only valid color tokens documented by Theme.d.ts.
Use optional chaining with fallbacks for platform-specific APIs, especially Linux-only process APIs such as process.getuid(), getgid(), geteuid(), and getegid().
Use TypeScript strict mode.
Redux actions must follow the Flux Standard Action pattern.
Use camelCase for file names and PascalCase for component names.
Avoid unnecessary comments; prefer self-documenting code through clear naming.
Do not commit or push without explicit user permission.
Verify library APIs, props, tokens, and types against official documentation and .d.ts files instead of assuming they are valid.

Files:

src/ui/components/Shell/index.tsx

**/*.{tsx,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use React functional components with hooks.

Files:

src/ui/components/Shell/index.tsx

🔇 Additional comments (1)

src/ui/components/Shell/index.tsx (1)

29-35: LGTM!

Also applies to: 45-48, 81-98, 104-159

Replace the hardcoded rgba(0, 0, 0, 0.14) inset box-shadow with Fuselage's shadow-elevation-border token so the outer hairline adapts to the active theme instead of staying fixed for dark mode.

coderabbitai Bot added the type: feature label Aug 10, 2026

coderabbitai Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread README.md Outdated

Comment thread src/app/main/data.ts

Comment thread src/ui/main/rootWindow.ts

jeanfbrito added 2 commits August 10, 2026 15:09

fix(ui): stop Linux horizontal scrollbar under rounded chrome

4b1795f

Use an inset hairline and clamp html/body/#root overflow so the outer corner radius no longer extends the document and shows a bottom scrollbar.

fix: address CodeRabbit feedback on menu bar docs and lint

1fb8974

Correct isMenuBarEnabled true/false wording in README and silent-install docs, and fix import order/formatting in data load helpers so CI lint passes.

coderabbitai Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/ui/components/Shell/index.tsx Outdated

fix(ui): use theme-aware token for Linux chrome hairline

a76742b

Replace the hardcoded rgba(0, 0, 0, 0.14) inset box-shadow with Fuselage's shadow-elevation-border token so the outer hairline adapts to the active theme instead of staying fixed for dark mode.

jeanfbrito merged commit a4b9469 into master Aug 10, 2026
12 of 13 checks passed

jeanfbrito deleted the fix/menu-bar-autohide-default-off branch August 10, 2026 19:26

jeanfbrito mentioned this pull request Aug 10, 2026

chore: bump version to 4.16.0 #3451

Merged

2 tasks

coderabbitai Bot mentioned this pull request Aug 11, 2026

feat: log viewer, downloads, settings and document viewer as separate windows on a shared native shell #3444

Merged

feat(ui): unify Windows/Linux shell chrome and menu bar by jeanfbrito · Pull Request #3450 · RocketChat/Rocket.Chat.Electron · GitHub

Uh oh!

feat(ui): unify Windows/Linux shell chrome and menu bar - #3450

feat(ui): unify Windows/Linux shell chrome and menu bar#3450
jeanfbrito merged 4 commits into
masterfrom
fix/menu-bar-autohide-default-off

jeanfbrito commented Aug 10, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat(ui): unify Windows/Linux shell chrome and menu bar by jeanfbrito · Pull Request #3450 · RocketChat/Rocket.Chat.Electron · GitHub

Uh oh!

feat(ui): unify Windows/Linux shell chrome and menu bar - #3450

feat(ui): unify Windows/Linux shell chrome and menu bar#3450jeanfbrito merged 4 commits intomasterRocketChat/Rocket.Chat.Electron:masterfrom fix/menu-bar-autohide-default-offRocketChat/Rocket.Chat.Electron:fix/menu-bar-autohide-default-offCopy head branch name to clipboard

Conversation

jeanfbrito commented Aug 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat(ui): unify Windows/Linux shell chrome and menu bar#3450
jeanfbrito merged 4 commits into
masterfrom
fix/menu-bar-autohide-default-off

jeanfbrito commented Aug 10, 2026 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Aug 10, 2026 •
edited
Loading