ci: build releases only on semver tags and run PR checks for release lines - #3454
Merged
jeanfbrito merged 1 commit intoAug 13, 2026
Merged
ci: build releases only on semver tags and run PR checks for release lines#3454jeanfbrito merged 1 commit into
jeanfbrito merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 7ee27122-a171-4216-9640-2b8d582ebe55 📥 CommitsReviewing files that changed from the base of the PR and between 5ec3255 and 1e4cbd0. 📒 Files selected for processing (4)
Learnt from: Ram-sah19 Repo: RocketChat/Rocket.Chat.Electron PR: 3254 File: .github/workflows/build-release.yml:80-94 Timestamp: 2026-03-11T06:38:40.426Z Learning: In the RocketChat/Rocket.Chat.Electron repository, the issues flagged in `.github/workflows/build-release.yml` (e.g., `node12` runtime in the release action and missing `snapcraft_token` input), i18n files, and `electron-builder.json` are pre-existing in the `develop` branch and are pulled in during merge conflict resolution. Do not flag these as new issues introduced by PRs that only modify `src/injected.ts` and `src/ui/main/rootWindow.ts`. Learnt from: Ram-sah19 Repo: RocketChat/Rocket.Chat.Electron PR: 3254 File: .github/workflows/build-release.yml:80-94 Timestamp: 2026-03-11T06:38:40.426Z Learning: In the RocketChat/Rocket.Chat.Electron repository, the issues flagged in `.github/workflows/build-release.yml` (e.g., `node12` runtime in the release action and missing `snapcraft_token` input), i18n files, and `electron-builder.json` are pre-existing in the `develop` branch and are pulled in during merge conflict resolution. Do not flag these as new issues introduced by PRs that only modify `src/injected.ts` and `src/ui/main/rootWindow.ts`. Applied to files:
.github/workflows/build-release.yml (1).github/workflows/powershell-lint.yml (1) WalkthroughThe GitHub Actions workflows now trigger release builds only for semantic version tags. PowerShell linting and pull request validation also run for branches matching release/**. ChangesWorkflow trigger updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Mergeability Score: ⚪ Minimal · up to 1e4cb This PR adjusts release and pull-request workflow triggers without any identified merge-blocking risk; it is merge-ready after normal checks and review. Suggested labels: type: chore Suggested reviewers: yasnagat 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the branching-model migration (dev = development branch, master = releases only, release/X.Y.x = patch lines).
What changed
Why
Under the new model, alphas are tagged on dev, stables on master (via dev→master release merges), and patches on release/X.Y.x lines. The tag-triggered release path in desktop-release-action is already branch-agnostic, so no action changes are needed — its per-push dev/snapshot code paths simply become unreachable (left in place deliberately to avoid rebuilding the committed dist/ bundle).
Validated with actionlint (only pre-existing, unrelated warnings reported).
Summary by CodeRabbit