FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

EX raid support by ibuckshot5 · Pull Request #2298 · RocketMap/RocketMap · GitHub

EX raid support - #2298

Open
ibuckshot5 wants to merge 4 commits into
RocketMap:developfrom
ibuckshot5:ex-raid-support
Open

EX raid support#2298
ibuckshot5 wants to merge 4 commits into
RocketMap:developfrom
ibuckshot5:ex-raid-support

Conversation

Copy link
Copy Markdown
Contributor

With Mewtwo coming to EX raids soon, support should be needed.

Description

Added the ability for RocketMap to tell normal raids apart from EX raids.

Motivation and Context

Mewtwo's coming out soon.

How Has This Been Tested?

Local installation

I haven't actually seen an EX raid though

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Contributor

Has this been tested with real scan data, I am not sure that ex raids will be shown to not invited players.

Also you need to fix travis and do a proper DB migration to add the new column

pogo-excalibur commented Sep 16, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

As people who can't participate in the raid get this message:

(from TSR: https://www.reddit.com/r/TheSilphRoad/comments/70d5sh/ex_raids_from_wave_2_now_display_gym_closure/)

There must be some way of detecting an EX raid.

But it looks like non-participants can't see the egg (the message above only appears once the raid actually starts), so how useful this will be is an open question.

sirlindqvist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please use css classes for FontAwesone padlock and bold text as we do for all the other styles.

SkOODaT commented Sep 17, 2017
edited
Loading

Copy link
Copy Markdown

exclusive raids are being "tested" so yes only invited players will be able to see it right now but when they go global im sure the "'exclusive': raid_info.is_exclusive" will still be used so i can see this possibly being useful some point... when they do activate globally tho im sure current setups will still post them as long as the assets are there and enabled, i added the basic mewtwo stuff a few weeks ago to my copy...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL