[In progress] Optimize L30 account selection - #2338
Closed
AEtHeLsYn wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
friscoMad
reviewed
Oct 11, 2017
Comment thread
pogom/account.py
Outdated
| account['last_scanned'] = now | ||
| account['last_coords'] = coords_to_scan | ||
| account['in_use'] = True | ||
| continue |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is not needed
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Fixed
Sorry, something went wrong.
KartulUdus
approved these changes
Oct 21, 2017
KartulUdus
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
ran -st 10 on -ss with and without -ssct 120
logs clean
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@AEtHeLsYn Are you going to continue this PR? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Nope, i stopped working on it |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@AEtHeLsYn Alright, thanks! 😄 PR closed so someone else can pick it up. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[In progress] Using this PR uses more L30 accounts than default account selection.
With this PR we improve the seleccion of level 30 accounts, not picking just the first one but the closest one within range. Combining this PR with #2336 improves greatly the amount of encounters that you can have with the same amount of accounts.
Motivation and Context
The change potentially optimizes the usage of level 30 accounts.
How Has This Been Tested?
Local testing map.
Screenshots (if appropriate):
Types of changes
Checklist: