Add "New Spawn" group to fix issue #2469. - #2487
Open
BrownSlaughter wants to merge 5 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sebastienvercammen
requested changes
Feb 27, 2018
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
- Missing update to get_pokemon_rarity in utils.py to return New Spawn for new spawns.
- updatePokemonRarities is only called once in the JS, so new spawns will stay new spawns until the visitor refreshes the page after a Pokémon has been scanned.
- 0 entries in DB = no data in rarities file = "New Spawn". But 1 entry isn't enough to define its rarity. (Arguably a problem that fixes itself with dynamic rarity and calling updatePokemonRarities on a timer.)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Is webhook support possible for 'New spawns' ? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Did you consider adding the 'New spawns' to the rarity exclusion filter? Also does this work with 'Hide Unnotified'? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a current issue of a brand new pokemon spawn and it will not be set a rarity until the dynamic rarity filer is updated.
We could set all new pokemon to ultra rare but for people who dont update rarity often this would mean things as common as pidgey would stay ultra rare until rarity file is next updated.
This way sets all new pokemon as a "New Spawn" and once the rarity file is updated it will be sorted properly. I added "New Spawn" to notify by rarity on the side bar and also included it in scale by rarity.
This will fix Issue #2469
How Has This Been Tested?
Tested on a live map and simulated new spawns to test it
Types of changes
Checklist: