FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make RM look nice by michikrug · Pull Request #2496 · RocketMap/RocketMap · GitHub

/ RocketMap Public

Make RM look nice - #2496

Closed
michikrug wants to merge 8 commits into
RocketMap:developfrom
michikrug:PR-style
ConversationCommits (8)ChecksFiles changed
Closed

Make RM look nice#2496
michikrug wants to merge 8 commits into
RocketMap:developfrom
michikrug:PR-style

Conversation

michikrug commented Feb 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This is a plain cosmetic PR that optimizes display of menu, marker labels and gym sidebar.
It already includes the changes proposed by #2476 and #2488. (Thanks to the authors!)

Motivation and Context

RM looks kinda messy currently.
The style ideas are nice, but poorly applied.
E.g.:

  • the labels did not use the same font as the rest of the page
  • inconsistent underlining
  • strange paddings / margins and font sizes
  • bad alignment
  • not the best responsive changes
  • ...

Thus, I optimized a LOT of styles to make RM look nice on desktop and mobile.

How Has This Been Tested?

Own instance.

Screenshots (if appropriate):

Old:

New:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

sebastienvercammen added this to the 4.1.1 milestone Feb 17, 2018
sebastienvercammen reviewed Feb 17, 2018
View reviewed changes

sebastienvercammen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To properly credit authors, pending merge of #2476 and #2488. We don't allow "combo PRs" which merge the work of other PRs that came before it. This PR has more than just the combo, so it can be rebased after those two are merged.

michikrug commented Feb 17, 2018

Copy link
Copy Markdown
Contributor Author

I'm totally fine with that.

michikrug commented Feb 19, 2018

Copy link
Copy Markdown
Contributor Author

Added some screenshots of raids.

michikrug commented Feb 19, 2018

Copy link
Copy Markdown
Contributor Author

Also added some screenshots of Pokémon label.

michikrug closed this Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sebastienvercammen sebastienvercammen left review comments

Assignees

No one assigned

Labels

enhancement front-end on hold

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL