FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow Pokemon downscaling after rarity upscale by Levonestral · Pull Request #2514 · RocketMap/RocketMap · GitHub

Allow Pokemon downscaling after rarity upscale - #2514

Open
Levonestral wants to merge 4 commits into
RocketMap:developfrom
Levonestral:allow_pokemon_downscale
Open

Allow Pokemon downscaling after rarity upscale#2514
Levonestral wants to merge 4 commits into
RocketMap:developfrom
Levonestral:allow_pokemon_downscale

Conversation

Levonestral commented Mar 4, 2018
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This allows you to choose any number of Pokemon and override their scaling to be "normal" instead of their assigned rarity scale.

Motivation and Context

Certain rarities of Pokemon result in a larger scaled display on the map. Although most of the time this is very helpful, there are some Pokemon that users may still not want to have larger (For example, Wobuffet for my users was not wanted to see larger scaled due to rarity).

RocketMap already allows the override the default size of 2 to make them larger, so this PR simply does the opposite and allows you to override the rarity size and force them back to 2 (normal).

How Has This Been Tested?

Smaller map. 5 instances, 300 accounts.

Screenshots (if appropriate):

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

sebastienvercammen left a comment
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Need to update this review. 👀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL