FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow custom hashing service + higher key values. by sebastienvercammen · Pull Request #2537 · RocketMap/RocketMap · GitHub

Allow custom hashing service + higher key values. - #2537

Merged
sebastienvercammen merged 3 commits into
RocketMap:developfrom
sebastienvercammen:endpoint
Mar 16, 2018
Merged

Allow custom hashing service + higher key values.#2537
sebastienvercammen merged 3 commits into
RocketMap:developfrom
sebastienvercammen:endpoint

Conversation

sebastienvercammen commented Mar 15, 2018
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Allow legal (in terms of law) hashing API service alternatives.
  • Allow higher HashKey values. RocketMap currently assumes the values always mean RPM, and SmallInteger limits it to only 32767.

Motivation and Context

Allow for devkat hashing.

How Has This Been Tested?

Untested.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

sebastienvercammen added this to the 4.1.1 milestone Mar 15, 2018
sebastienvercammen changed the title Allow custom endpoint + higher key values. Allow custom hashing service + higher key values. Mar 16, 2018

fosJoddie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

-hs dvekat :

-hs bossland 👌
-hs devkat 👌
no argument (bossland): 👌

Higher key values:

sebastienvercammen merged commit b853ff0 into RocketMap:develop Mar 16, 2018
sebastienvercammen deleted the endpoint branch March 16, 2018 18:19
pki0 pushed a commit to pki0/RocketMap that referenced this pull request Mar 19, 2018
* Allow custom hashing service + higher key values.

* Make service case insensitive.

* Require specific choices.

(cherry picked from commit b853ff0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL