FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update User-Agent with the most recent version by myprivateproxy · Pull Request #2548 · RocketMap/RocketMap · GitHub

/ RocketMap Public

Update User-Agent with the most recent version - #2548

Open
myprivateproxy wants to merge 1 commit into
RocketMap:developfrom
myprivateproxy:fix-user-agent
ConversationCommits (1)ChecksFiles changed
Open

Update User-Agent with the most recent version#2548
myprivateproxy wants to merge 1 commit into
RocketMap:developfrom
myprivateproxy:fix-user-agent

Conversation

myprivateproxy commented Mar 21, 2018

Copy link
Copy Markdown

Description

User-Agent header is too old and it should be updated

Motivation and Context

This fix possibly helps to prevent detecting a suspicious traffic and a resulting ban of proxies

How Has This Been Tested?

New header is from mitmproxy and a real PokémonGo on iOS

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

FrostTheFox commented Mar 21, 2018

Copy link
Copy Markdown
Member

Unlikely to be a major issue as this UA is CFNetwork and Darwin versions (which are generally speaking relative to iOS version, and thus not really an issue, as these current UAs were pulled from my own iPhone devices a couple iOS versions ago).

Still good to update though.

myprivateproxy commented Mar 21, 2018

Copy link
Copy Markdown
Author

The answer is 'a couple iOS versions ago'. Most users update iOS within a week. Nevermind.

FrostTheFox commented Mar 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Okay, and? Niantic nor PTC are going to ban someone because they are using older iOS versions. We're talking within the major iOS version (so something like 11.1) here. I'm not speaking of iOS 8 here.\

I don't disagree with the change, otherwise I would have closed the PR. I don't think it's a MAJOR MERGE ASAP change though.

FrostTheFox approved these changes Mar 21, 2018
View reviewed changes

FrostTheFox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Checked these headers under latest iOS, iPhone X.

sebastienvercammen added this to the 4.1.1 milestone Mar 22, 2018
fosJoddie approved these changes Mar 22, 2018
View reviewed changes

fosJoddie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These changes on it's own works fine (proxies are still banned).

However it is worth to point out that these changes ONLY changes the user agent of the proxy checks.

The user agent used for actual requests are defined in the pgoapi.

sebastienvercammen requested changes Mar 22, 2018
View reviewed changes

sebastienvercammen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

PR also requires a pgoapi User-Agent update.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sebastienvercammen sebastienvercammen requested changes
FrostTheFox FrostTheFox approved these changes
+1 more reviewer
fosJoddie fosJoddie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement minor pending changes

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL