Repository navigation
str.isprintable - #1024
Merged
coolreader18 merged 1 commit intoJun 9, 2019
Merged
str.isprintable#1024coolreader18 merged 1 commit into
coolreader18 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 64.7% 64.71% +0.01%
==========================================
Files 97 97
Lines 17041 17047 +6
Branches 3799 3800 +1
==========================================
+ Hits 11026 11032 +6
Misses 3441 3441
Partials 2574 2574
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Comment thread
vm/src/obj/objstr.rs
Outdated
Comment thread
vm/src/obj/objstr.rs
Outdated
Copy link
Copy Markdown
Contributor
|
@yanganto thank you for contributing to this project! I left some review comments in your changes. |
Sorry, something went wrong.
yanganto
force-pushed
the
str_isprintable
branch
4 times, most recently
from
53adcc9 to
c8d45a1
Compare
June 9, 2019 12:54
coolreader18
approved these changes
Jun 9, 2019
- check unicode type by unicode_categories - rm redundant check of empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement isprintable function of str object