Repository navigation
Remove old import - #1102
Merged
coolreader18 merged 4 commits intoJul 4, 2019
Merged
Remove old import#1102coolreader18 merged 4 commits into
coolreader18 merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
vm/src/import.rs
| import_frozen(vm, module_name) | ||
| } else if vm.stdlib_inits.borrow().contains_key(module_name) { | ||
| import_builtin(vm, module_name) | ||
| } else if cfg!(feature = "rustpython-compiler") { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The point of this feature flag was to check if rustpython was built with bytecode compiler support. If not, the module cannot be loaded from disc. I think importlib.py has a similar mechanism. Please refer to the function imp_exec_builtin in imp.rs. Maybe the logic deleted here, can be replicated over there?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Only the external_importers use compile now. So I changed init_importlib to not install them if there is not compiler.
Sorry, something went wrong.
Comment thread
vm/src/stdlib/thread.rs
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.