FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable clippy in CI by mkurnikov · Pull Request #1114 · RustPython/RustPython · GitHub

Repository navigation

Enable clippy in CI - #1114

Merged
windelbouwman merged 3 commits into
RustPython:masterfrom
mkurnikov:fix-clippy-1.36
Jul 7, 2019
Merged

windelbouwman merged 3 commits into
RustPython:masterfrom
mkurnikov:fix-clippy-1.36

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

mkurnikov changed the title Enable clippy in the CI Enable clippy in CI Jul 7, 2019
Comment thread .travis.yml Outdated
Comment thread .travis.yml
env:
- JOBCACHE=3

- name: Lint code with clippy

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does it make sense to combine the rustfmt check with this check to reduce the amount of different jobs? We could add cargo clippy --all to the rustfmt job above.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is there a way to make them appear in a different rows in the Travis output? I'd like to spare user from looking inside the Travis row to see what's going on. He sees that formatter failed, goes to his own terminal, runs it, creates new commit.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay, that sounds fair to me.

windelbouwman merged commit dbc263c into RustPython:master Jul 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL