Repository navigation
Add some extra profiling trace points. - #1169
Merged
coolreader18 merged 6 commits intoJul 24, 2019
Merged
coolreader18 merged 6 commits into
coolreader18 merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
coolreader18
approved these changes
Jul 24, 2019
Comment thread
vm/src/dictdatatype.rs
| @@ -271,6 +273,7 @@ enum LookupResult { | |||
| Existing(EntryIndex), // Existing record, index into entries | |||
| } | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The string passed to flame is a prefix, so this would appear in the output as collection_hash::collection_hash. I'd recommend changing it to dictdatatype or removing the prefix altogether.
Sorry, something went wrong.
Comment thread
vm/src/pyobject.rs
| @@ -1021,6 +1021,8 @@ pub trait ItemProtocol { | |||
| vm: &VirtualMachine, | |||
| ) -> PyResult; | |||
| fn del_item<T: IntoPyObject>(&self, key: T, vm: &VirtualMachine) -> PyResult; | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This should probably be flame("ItemProtocol")?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some extra tracepoints. This gives a nice hint on where to improve.
To run this, use: cargo run --features flame-it demo.py and upload flamescope.json into http://speedscope.app
Also moved the get_item_option function into the PyDictRef struct, since it was only used for that case.