Repository navigation
Add empty tuple optimization - #1178
Merged
windelbouwman merged 2 commits intoJul 25, 2019
Merged
windelbouwman merged 2 commits into
windelbouwman merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
coolreader18
force-pushed
the
coolreader18/empty-tuple
branch
from
9f3a26e to
dfa66b0
Compare
July 25, 2019 06:35
Copy link
Copy Markdown
Contributor
|
Hmm, this is interesting, and I would rather not do this. But actually this solves this example: >>> a = ()
>>> b = ()
>>> a is b
TruePlease add a test snippet for this special case. |
Sorry, something went wrong.
Comment thread
src/main.rs
Outdated
| fn run_module(vm: &VirtualMachine, module: &str) -> PyResult<()> { | ||
| debug!("Running module {}", module); | ||
| vm.import(module, &vm.ctx.new_tuple(vec![]), 0)?; | ||
| vm.import(module, &vm.ctx.empty_tuple(), 0)?; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please do not use this empty tuple directly, and make it a private method on PyContext. I think it is better to call the new_tuple function with an empty vector, so we have one way to create a tuple.
Sorry, something went wrong.
Comment thread
vm/src/pyobject.rs
Outdated
| self.not_implemented.clone().into_object() | ||
| } | ||
|
|
||
| pub fn empty_tuple(&self) -> PyObjectRef { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think this method could be private, or merged into the new_tuple function.
Sorry, something went wrong.
coolreader18
force-pushed
the
coolreader18/empty-tuple
branch
from
dfa66b0 to
8aee745
Compare
July 25, 2019 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yeah, not all that big of an optimization, but it seemed dumb to be allocating a new Rc for something that's essentially empty.