FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

builtin: Fix hex format of ascii by corona10 · Pull Request #1188 · RustPython/RustPython · GitHub

Repository navigation

builtin: Fix hex format of ascii - #1188

Merged
windelbouwman merged 3 commits into
RustPython:masterfrom
corona10:hex_format
Jul 31, 2019
Merged

windelbouwman merged 3 commits into
RustPython:masterfrom
corona10:hex_format

Conversation

Copy link
Copy Markdown
Contributor

Some range of Unicode characters should be specially handled

corona10 commented Jul 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@windelbouwman

PTA
Sorry, I found some of more cases to deal with.
I will ping you after handling them

corona10 changed the title builtin: Fix hex format of ascii [WIP] builtin: Fix hex format of ascii Jul 28, 2019
corona10 changed the title [WIP] builtin: Fix hex format of ascii builtin: Fix hex format of ascii Jul 31, 2019

Copy link
Copy Markdown
Contributor Author

@windelbouwman

PTAL

Copy link
Copy Markdown
Contributor

Hi @corona10 , what does PTA and PTAL mean?

Comment thread vm/src/builtins.rs Outdated
Comment thread vm/src/builtins.rs Outdated

Copy link
Copy Markdown
Contributor Author

@windelbouwman

PTAL stands for 'Please take a look' :) (PTA was my typo.. sorry)
I 've updated your review, Thanks for the review with cool tips!

windelbouwman merged commit c2ec66f into RustPython:master Jul 31, 2019
corona10 deleted the hex_format branch July 31, 2019 11:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL