Repository navigation
byte.decode - #1193
Merged
coolreader18 merged 1 commit intoAug 1, 2019
Merged
byte.decode#1193coolreader18 merged 1 commit into
coolreader18 merged 1 commit into
Conversation
yanganto
force-pushed
the
feat/byte-decode
branch
2 times, most recently
from
9d6c4fa to
2f4613b
Compare
July 31, 2019 16:16
coolreader18
approved these changes
Jul 31, 2019
coolreader18
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, I left a comment and the clippy build is failing, but address those and I'll merge.
Sorry, something went wrong.
Comment thread
vm/src/obj/objbytes.rs
| // utf-8 is default encoding | ||
| _ => { | ||
| let mut p: u32 = 0u32; | ||
| let mut remaining_bytes = 0; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
utf-8 is the default, but cpython throws a LookupError if you give it an invalid encoding.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Got it, I will implement this.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done :)
Sorry, something went wrong.
yanganto
force-pushed
the
feat/byte-decode
branch
from
2f4613b to
0ad1c59
Compare
July 31, 2019 17:16
- support ascii, utf-8 encoding - raise LookupError for unhandled encoding
yanganto
force-pushed
the
feat/byte-decode
branch
from
0ad1c59 to
0f4c2c1
Compare
August 1, 2019 14:57
Copy link
Copy Markdown
Contributor
Author
|
@coolreader18 thanks for your review. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.