FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump up to python 3.7 for Azure Pipelines by youknowone · Pull Request #1705 · RustPython/RustPython · GitHub

  1. RustPython
  2. RustPython

Repository navigation

Bump up to python 3.7 for Azure Pipelines - #1705

Merged
youknowone merged 1 commit into
RustPython:masterfrom
youknowone:azure-38
Feb 5, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Bump up to python 3.7 for Azure Pipelines#1705
youknowone merged 1 commit into
RustPython:masterfrom
youknowone:azure-38

Conversation

youknowone commented Jan 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Split from #1703

coolreader18 approved these changes Jan 28, 2020
View reviewed changes
Comment thread azure-pipelines.yml Outdated
Python36:
python.version: '3.6'
Python38:
python.version: '3.8'

coolreader18 Jan 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we can embed this directly in the UsePythonVersion task; I'm pretty sure this is what's causing the 2 different Azure jobs to run.

youknowone commented Jan 28, 2020

Copy link
Copy Markdown
Member Author

windows snippets test fail with python 3.8 but I don't have windows macine.

palaviv commented Jan 28, 2020

Copy link
Copy Markdown
Contributor

It seems like os.path.realpath was changed in 3.8.

coolreader18 commented Jan 29, 2020

Copy link
Copy Markdown
Member

The os.path.realpath implementation for 3.8 is pretty complex and requires a fairly complex os module function, it might be best to comment it out for windows right now and put a TODO.

youknowone changed the title Bump up to python 3.8 for Azure Pipelines Bump up to python 3.7 for Azure Pipelines Feb 5, 2020

youknowone commented Feb 5, 2020

Copy link
Copy Markdown
Member Author

Changed to python3.7 for azure

youknowone merged commit 0f12db1 into RustPython:master Feb 5, 2020
youknowone deleted the azure-38 branch February 5, 2020 19:31
palaviv mentioned this pull request Feb 11, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coolreader18 coolreader18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL