| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Looks good! This PR can be a good specimen for the other remaining works. Does "three items" mean OSError, ImportError, BaseException? |
Sorry, something went wrong.
Yes. I only had to add things to BaseException, since ImportError and OSError inherit from BaseException. |
Sorry, something went wrong.
|
Unfortunately, OSError's and ImportError's reduce act different than BaseException's 😭 |
Sorry, something went wrong.
I would direct future contributors to look at the extend_exception! macro. |
Sorry, something went wrong.
|
Ok good 😊. Except for the issue about the empty set that I commented on, everything seems fine. |
Sorry, something went wrong.
There was a problem hiding this comment.
great, thank you! @Snowapril and thank you for the review!
Sorry, something went wrong.
| } | ||
|
|
||
| #[pymethod(magic)] | ||
| fn reduce(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyTupleRef { |
There was a problem hiding this comment.
If it doesn't require type checking, this may be:
| fn reduce(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyTupleRef { | |
| fn reduce(zelf: PyObjectRef, vm: &VirtualMachine) -> PyTupleRef { |
Sorry, something went wrong.
There was a problem hiding this comment.
It doesn't work in practice because rustc will complain:
no method named `args` found for struct `core::PyObjectRef` in the current scope
method not found in `core::PyObjectRef`
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Addresses three items in #3611.
cc @Snowapril