Repository navigation
Add count.reduce() - #3737
Merged
youknowone merged 4 commits intoMay 22, 2022
Merged
Add count.reduce()#3737youknowone merged 4 commits into
youknowone merged 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
are there related tests in test_itertools.py? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
test_count() has a pickle-related section. |
Sorry, something went wrong.
22 of 27 tasks
youknowone
requested changes
May 22, 2022
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is not compatible to pickle
Sorry, something went wrong.
youknowone
requested changes
May 22, 2022
Comment thread
vm/src/stdlib/itertools.rs
Outdated
| Ok(*times.read()) | ||
| } | ||
|
|
||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
Sorry, something went wrong.
Comment thread
vm/src/stdlib/itertools.rs
Outdated
| #[pyimpl(with(IterNext, Constructor))] | ||
| impl PyItertoolsCount {} | ||
| impl PyItertoolsCount { | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
Sorry, something went wrong.
youknowone
approved these changes
May 22, 2022
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thank you for contributing!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #3611