Repository navigation
Fill OSError attributes - #4194
Merged
youknowone merged 1 commit intoOct 4, 2022
Merged
youknowone merged 1 commit into
youknowone merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dvermd
force-pushed
the
oserror_attributes
branch
3 times, most recently
from
8265033 to
47a3bda
Compare
October 2, 2022 20:50
Merged
Copy link
Copy Markdown
Contributor
Author
|
From the discussion in #4191, there seems to be 2 different behaviors of the OSError constructor:
|
Sorry, something went wrong.
dvermd
force-pushed
the
oserror_attributes
branch
2 times, most recently
from
b1ece8e to
8ad3f3f
Compare
October 3, 2022 21:03
youknowone
reviewed
Oct 4, 2022
Comment thread
Lib/test/test_exceptions.py
Outdated
dvermd
force-pushed
the
oserror_attributes
branch
from
8ad3f3f to
5f04da0
Compare
October 4, 2022 10:19
dvermd
force-pushed
the
oserror_attributes
branch
from
5f04da0 to
a18bad2
Compare
October 4, 2022 11:34
youknowone
approved these changes
Oct 4, 2022
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by removing expected failure and commenting everything but OSError in Lib/test/test_exceptions.py::testAttributes::exceptionList, WindowsError and pickling part of the test.
fixes : #4193