Repository navigation
Add combinations.__reduce__ - #4272
Merged
youknowone merged 2 commits intoNov 18, 2022
Merged
youknowone merged 2 commits into
youknowone merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mumallaeng
marked this pull request as ready for review
November 9, 2022 21:03
22 of 27 tasks
Copy link
Copy Markdown
Contributor
Author
|
Sorry. I didn‘t know how to use github cli. But now that I know how to use it, I merged the original PR! |
Sorry, something went wrong.
Add result in struct PyItertoolsCombinations
youknowone
force-pushed
the
iter_combi_reduce
branch
from
52e72f8 to
d524717
Compare
November 11, 2022 07:38
youknowone
force-pushed
the
iter_combi_reduce
branch
from
d524717 to
dd93ec3
Compare
November 11, 2022 07:41
Copy link
Copy Markdown
Member
|
Hm, @oow214 have you coordinated with @seryoungshim17 on this? I'm unsure which of the PRs to review. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I wrote the code after looking at the cpython code https://github.com/python/cpython/blob/main/Modules/itertoolsmodule.c#L2937-#L2965. |
Sorry, something went wrong.
youknowone
approved these changes
Nov 18, 2022
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add combinations.__reduce__ #3611 and fix next