Repository navigation
Implement itertools.accumulate.__reduce__ and __setstate__ - #4434
Merged
youknowone merged 2 commits intoJun 12, 2023
Merged
youknowone merged 2 commits into
youknowone merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
22 of 27 tasks
Copy link
Copy Markdown
Member
|
Because you fixed related bug from the test suites, you can remove @unittest.expectedFailure decorator from test_accumulate_reducible test |
Sorry, something went wrong.
DimitrisJim
force-pushed
the
accumulate-reduce
branch
2 times, most recently
from
0de70f9 to
e918d56
Compare
May 19, 2023 15:32
DimitrisJim
marked this pull request as ready for review
May 19, 2023 19:44
DimitrisJim
force-pushed
the
accumulate-reduce
branch
from
e918d56 to
dd469e2
Compare
June 11, 2023 13:30
youknowone
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accumulate.reduce implementation for #3611.
Publishing as a draft to collect initial feedback. Behaviour seems to be identical to CPython's, but I'm still testing.
Relevant links