FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(configparser): update to 3.11 by carlosmiei · Pull Request #4595 · RustPython/RustPython · GitHub

/ RustPython Public

feat(configparser): update to 3.11 - #4595

Merged
youknowone merged 4 commits into
RustPython:mainfrom
carlosmiei:configparser
Mar 1, 2023
ConversationCommits (4)ChecksFiles changed
Merged

feat(configparser): update to 3.11#4595
youknowone merged 4 commits into
RustPython:mainfrom
carlosmiei:configparser

Conversation

carlosmiei commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Test

RUSTPYTHONPATH=Lib cargo run --release Lib/test/test_configparser.py
    Updating git repository `https://github.com/youknowone/unicode_names2.git`
    Finished release [optimized] target(s) in 0.92s
     Running `target/release/rustpython Lib/test/test_configparser.py`
...
Ran 343 tests in 1.312s

OK (skipped=5)

youknowone mentioned this pull request Feb 28, 2023
Closed
DimitrisJim reviewed Feb 28, 2023
View reviewed changes
Comment thread Lib/test/test_configparser.py
cf.get(self.default_section, "Foo"), "Bar",
"could not locate option, expecting case-insensitive defaults")

@unittest.skipIf(os.name == "nt", "TODO: RUSTPYTHON, universal newlines")

DimitrisJim Feb 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

probably need to add this again, it skipped the tests for windows (which are now failing)

carlosmiei Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim restored thanks

fanninpm commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

When I update a library from a newer version of CPython, I usually do this:

  1. Copy/paste the library straight from CPython unless it has any RustPython-related annotations, and put that into the first commit. (Your first commit is fine as is, but personally, I would title it Update configparser.py from CPython 3.11 in accordance with this guide.)
  2. Copy/paste the test straight from CPython, without touching the RustPython-related annotations, and put that into a second commit, titled something like Update test_configparser.py from CPython 3.11. (You can follow the guide in the wiki, but I use Meld for this.)
  3. Run the new test. Add/remove any necessary RustPython-related annotations, and put that into one or more commits, titled something like Mark failing/erroring tests or Unmark passing tests or Skip panicking test.

youknowone commented Mar 1, 2023

Copy link
Copy Markdown
Member

#4597 will make it simpler

carlosmiei commented Mar 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

When I update a library from a newer version of CPython, I usually do this:

  1. Copy/paste the library straight from CPython unless it has any RustPython-related annotations, and put that into the first commit. (Your first commit is fine as is, but personally, I would title it Update configparser.py from CPython 3.11 in accordance with this guide.)
  2. Copy/paste the test straight from CPython, without touching the RustPython-related annotations, and put that into a second commit, titled something like Update test_configparser.py from CPython 3.11. (You can follow the guide in the wiki, but I use Meld for this.)
  3. Run the new test. Add/remove any necessary RustPython-related annotations, and put that into one or more commits, titled something like Mark failing/erroring tests or Unmark passing tests or Skip panicking test.

@fanninpm thanks for your suggestions, I was trying to follow conventional commits convention but will stick with your advice next time.

youknowone approved these changes Mar 1, 2023
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! many more tests run successful 😄

youknowone merged commit e731e65 into RustPython:main Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DimitrisJim DimitrisJim left review comments
youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL