FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update test_baseexception.py from cpython 3.11.2 by dalinaum · Pull Request #4624 · RustPython/RustPython · GitHub

/ RustPython Public

Update test_baseexception.py from cpython 3.11.2 - #4624

Merged
youknowone merged 2 commits into
RustPython:mainfrom
dalinaum:test_baseexception
Mar 4, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Update test_baseexception.py from cpython 3.11.2#4624
youknowone merged 2 commits into
RustPython:mainfrom
dalinaum:test_baseexception

Conversation

dalinaum commented Mar 4, 2023

Copy link
Copy Markdown
Contributor

fanninpm mentioned this pull request Mar 4, 2023
Closed

fanninpm commented Mar 4, 2023

Copy link
Copy Markdown
Contributor

Please break any RustPython-related lines into a separate commit. This makes the git blame easier to keep track of.

dalinaum commented Mar 4, 2023

Copy link
Copy Markdown
Contributor Author

@fanninpm Sure, I just split the previous commit into two commits.

youknowone approved these changes Mar 4, 2023
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

youknowone merged commit ab7971d into RustPython:main Mar 4, 2023
fanninpm reviewed Mar 4, 2023
View reviewed changes
Comment thread Lib/test/test_baseexception.py
Comment on lines +33 to +35
inheritance_tree = open(
os.path.join(os.path.split(__file__)[0], 'exception_hierarchy.txt'),
encoding="utf-8")

fanninpm Mar 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One thing: since this references a file named exception_hierarchy.txt, it would make sense if it could also be brought up to date.

dalinaum Mar 4, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I uploaded it as a PR #4627.

dalinaum deleted the test_baseexception branch March 4, 2023 20:19
dalinaum mentioned this pull request Mar 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fanninpm fanninpm left review comments
youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL