FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change error type for bad objects in "with" and "async with" by dalinaum · Pull Request #4656 · RustPython/RustPython · GitHub

/ RustPython Public

Change error type for bad objects in "with" and "async with" - #4656

Merged
youknowone merged 1 commit into
RustPython:mainfrom
dalinaum:with-type-error
Mar 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Change error type for bad objects in "with" and "async with"#4656
youknowone merged 1 commit into
RustPython:mainfrom
dalinaum:with-type-error

Conversation

dalinaum commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

This patch does not cover all cases of test_contextlib.py

bytecode::Instruction::SetupWith and BeforeAsyncWith raise a TypeError instead of an AttributeError.

It relates to #4650

dalinaum commented Mar 7, 2023
View reviewed changes
Comment thread vm/src/frame.rs Outdated
youknowone approved these changes Mar 7, 2023
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

contextlib seemed to related to contextlib.py version.
so this patch is fully fixing the with changes in 3.11. right?

Comment thread vm/src/frame.rs

dalinaum commented Mar 7, 2023

Copy link
Copy Markdown
Contributor Author

@youknowone I'm going to replace contextlib.py and test again.

Change error type for bad objects in "with" and "async with"
ef77e45 
This patch does not cover all cases of `test_contextlib.py`

`bytecode::Instruction::SetupWith` and `BeforeAsyncWith`
raise a TypeError instead of an AttributeError.

Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>

dalinaum commented Mar 7, 2023

Copy link
Copy Markdown
Contributor Author

@youknowone #4659 fixed 3 tests in text_conextlib.py and this patch fixed 2 tests.

However, there are still expectedFailures that were added during updating test_contextlib.py and contextlib.py.

youknowone commented Mar 7, 2023

Copy link
Copy Markdown
Member

at least, they are not regressions ;)

youknowone merged commit bdce56d into RustPython:main Mar 7, 2023

youknowone commented Mar 7, 2023

Copy link
Copy Markdown
Member

Thank you for contributing!

dalinaum deleted the with-type-error branch March 8, 2023 00:59
youknowone mentioned this pull request Mar 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL