Update _compression, gzip, and test_gzip for CPython v3.11.2 - #4688
Conversation
Sorry, something went wrong.
youknowone
left a comment
There was a problem hiding this comment.
That's really good decision 😄
thank you!
Sorry, something went wrong.
| @@ -1,7 +1,7 @@ | |||
| """Internal classes used by the gzip, lzma and bz2 modules""" | |||
There was a problem hiding this comment.
by looking the header, bz2 also seems to depending on here. could you also update it?
Sorry, something went wrong.
There was a problem hiding this comment.
We have no bz2 rust library, unfortunately.
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah, I hit the SkipTest: No module named ' bz2' when I copied over and ran the test_bz2.py as there were no changes in the Lib/bz2.py. Would this be connected to the bz2.rs in stdlib/src/
Sorry, something went wrong.
| # sys.maxsize means the max length of output buffer is unlimited, | ||
| # so that the whole input buffer can be decompressed within one | ||
| # .decompress() call. | ||
| while data := self.read(sys.maxsize): |
There was a problem hiding this comment.
maybe we don't support this operator yet
Sorry, something went wrong.
Sorry, something went wrong.
youknowone
left a comment
There was a problem hiding this comment.
looks good, thank you!
Sorry, something went wrong.
Updated _compression.py to match CPython v3.11.2. I didn't see any immediate unit test for this, so it seemed fit to test using a library that relies on _compression.py. I updated gzip.py / test_gzip.py and accounted for the unexpected failures on test_gzip.py.
The failures were primarily wbit errors tracing to stdlib/src/zlib.rs, but I am not familiar enough with this module in rust to correct the issues.