FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

update test_builtin.py from cpython v3.11.2 by JaeyoungAhn · Pull Request #4765 · RustPython/RustPython · GitHub

/ RustPython Public

update test_builtin.py from cpython v3.11.2 - #4765

Merged
DimitrisJim merged 4 commits into
RustPython:mainfrom
JaeyoungAhn:built_in
Mar 25, 2023
ConversationCommits (4)ChecksFiles changed
Merged

update test_builtin.py from cpython v3.11.2#4765
DimitrisJim merged 4 commits into
RustPython:mainfrom
JaeyoungAhn:built_in

Conversation

JaeyoungAhn commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

#4564 update test_builtin.py from cpython v3.11.2

DimitrisJim reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py

DimitrisJim commented Mar 25, 2023

Copy link
Copy Markdown
Member

thanks! There's some additional regressions here which should be noted: test_delattr, test_getattr, test_hasattr and test_setattr should probably all be related. test_type_name is also failing now.

DimitrisJim mentioned this pull request Mar 25, 2023
Closed
DimitrisJim approved these changes Mar 25, 2023
View reviewed changes

DimitrisJim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

hopefully should be good to go now.

DimitrisJim merged commit cfed9f3 into RustPython:main Mar 25, 2023
youknowone added A-design About RustPython's own implementation z-ca-2023 Tag to track contrubution-academy 2023 labels Mar 25, 2023
youknowone reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
(' ', ValueError),
(' \t\t ', ValueError),
# (str(br'\u0663\u0661\u0664 ','raw-unicode-escape'), 314), XXX RustPython
(str(br'\u0663\u0661\u0664 ','raw-unicode-escape'), 314),

youknowone Mar 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Comment thread Lib/test/test_builtin.py
self.assertEqual(type(round(x, None)), type(round(x)))

# TODO: RUSTPYTHON
@unittest.expectedFailure

youknowone Mar 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixing this one is looking like a good first issue

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

youknowone added A-stdlib and removed A-design About RustPython's own implementation labels Mar 25, 2023
fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +526 to +527
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +760 to +761
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +794 to +795
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +815 to +816
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +839 to +840
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +950 to +951
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +963 to +964
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm reviewed Mar 25, 2023
View reviewed changes
Comment thread Lib/test/test_builtin.py
Comment on lines +2413 to +2414
# TODO: RUSTPYTHON
@unittest.expectedFailure

fanninpm Mar 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DimitrisJim I believe this should have been broken out into a separate commit.

DimitrisJim mentioned this pull request Mar 27, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone left review comments
fanninpm fanninpm left review comments
DimitrisJim DimitrisJim approved these changes

Assignees

No one assigned

Labels

A-stdlib z-ca-2023 Tag to track contrubution-academy 2023

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL