Add encoding="locale" support for TextIOWrapper - #4781
Merged
youknowone merged 2 commits intoMar 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
youknowone
requested changes
Mar 26, 2023
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
And you fixed 2 more tests by this change!
UNEXPECTED SUCCESS: test__getitem___deprecation (test.test_fileinput.FileInputTests.test__getitem___deprecation) UNEXPECTED SUCCESS: test_gz_ext_fake (test.test_fileinput.Test_hook_compressed.test_gz_ext_fake)
Please remove unittest.expectedFailure from those tests
Sorry, something went wrong.
youknowone
requested changes
Mar 27, 2023
Comment thread
vm/src/stdlib/io.rs
Outdated
youknowone
approved these changes
Mar 28, 2023
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you for contributing!
Sorry, something went wrong.
I also changed the type from u8 to bool. No difference functionality-wise.
youknowone
reviewed
Mar 28, 2023
Comment thread
vm/src/stdlib/io.rs
Outdated
| None => { | ||
| // TODO: try os.device_encoding(fileno) and then locale.getpreferredencoding() | ||
| PyStr::from(crate::codecs::DEFAULT_ENCODING).into_ref(&vm.ctx) | ||
| None if vm.state.settings.utf8_mode == 1 => PyStr::from("utf-8").into_ref(&vm.ctx), |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| None if vm.state.settings.utf8_mode == 1 => PyStr::from("utf-8").into_ref(&vm.ctx), | |
| None if vm.state.settings.utf8_mode > 0 => PyStr::from("utf-8").into_ref(&vm.ctx), |
Sorry, something went wrong.
youknowone
added this pull request to the merge queue
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4662