Update test_cmd_line from Cpython v3.11.2 - #4801
Merged
DimitrisJim merged 5 commits intoApr 9, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
A couple of successes: UNEXPECTED SUCCESS: test_optimize (test.test_cmd_line.CmdLineTest.test_optimize)
UNEXPECTED SUCCESS: test_output_newline (test.test_cmd_line.CmdLineTest.test_output_newline)
UNEXPECTED SUCCESS: test_site_flag (test.test_cmd_line.CmdLineTest.test_site_flag)and a couple of failures: FAIL: test_tokenizer_error_with_stdin (test.test_cmd_line.SyntaxErrorTests.test_tokenizer_error_with_stdin)
FAIL: test_decoding_error_at_the_end_of_the_line (test.test_cmd_line.SyntaxErrorTests.test_decoding_error_at_the_end_of_the_line)
FAIL: test_xoption_frozen_modules (test.test_cmd_line.CmdLineTest.test_xoption_frozen_modules) []
FAIL: test_xoption_frozen_modules (test.test_cmd_line.CmdLineTest.test_xoption_frozen_modules) [=]
FAIL: test_xoption_frozen_modules (test.test_cmd_line.CmdLineTest.test_xoption_frozen_modules) [=on]
FAIL: test_int_max_str_digits (test.test_cmd_line.CmdLineTest.test_int_max_str_digits)
FAIL: test_help_xoptions (test.test_cmd_line.CmdLineTest.test_help_xoptions)
FAIL: test_help_env (test.test_cmd_line.CmdLineTest.test_help_env)
FAIL: test_help_all (test.test_cmd_line.CmdLineTest.test_help_all)
FAIL: test_help (test.test_cmd_line.CmdLineTest.test_help)
ERROR: test_non_interactive_output_buffering (test.test_cmd_line.CmdLineTest.test_non_interactive_output_buffering) |
Sorry, something went wrong.
fanninpm
reviewed
Apr 4, 2023
Comment thread
Lib/test/test_cmd_line.py
| b"'abc\\n'") | ||
|
|
||
| # TODO: RUSTPYTHON | ||
| @unittest.skipIf(sys.platform.startswith('win'), "TODO: RUSTPYTHON windows has \n troubles") |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think other tests are marked TODO: RUSTPYTHON, universal newlines, but I like this description better, as it's a clearer statement of the problem.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice, this can probably be opened as an issue, seems like it wouldn't be too difficult to fix.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
2 more windows issues FAIL: test_output_newline (test.test_cmd_line.CmdLineTest.test_output_newline) FAIL: test_stdin_readline (test.test_cmd_line.CmdLineTest.test_stdin_readline) |
Sorry, something went wrong.
DimitrisJim
approved these changes
Apr 9, 2023
DimitrisJim
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks! lgtm!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.