FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib by Masorubka1 · Pull Request #4835 · RustPython/RustPython · GitHub

/ RustPython Public

Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib - #4835

Merged
youknowone merged 4 commits into
RustPython:mainfrom
Masorubka1:test_hashlib.py
Apr 23, 2023
ConversationCommits (4)ChecksFiles changed
Merged

Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib#4835
youknowone merged 4 commits into
RustPython:mainfrom
Masorubka1:test_hashlib.py

Conversation

Masorubka1 commented Apr 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. split hashlib and _hashlib
  2. add libraries: _md5, _sha1, _sha3, _sha256, _blake2
  3. add tests for hashlib

fanninpm commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Hmm… I think we need to split up stdlib/src/hashlib.rs into different modules and turn hashlib into a pure-Python module. What do you think, @youknowone?

DimitrisJim mentioned this pull request Apr 4, 2023
Closed

youknowone commented Apr 5, 2023

Copy link
Copy Markdown
Member

hashlib.py strongly supposes _hashlib is cpython-like openssl implementation. It will require efforts.
In my opinion, that's more like test-purpose compatibility rather than actual compatiblity. But I will happily take patch if anyone want to work on it.

Masorubka1 changed the title Update test_hashlib.py from Cpython v3.11.2 [WIP] Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib Apr 9, 2023
Masorubka1 changed the title [WIP] Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib Apr 16, 2023

Masorubka1 commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

@youknowone Could you review this pr?

fanninpm reviewed Apr 18, 2023
View reviewed changes
Comment thread stdlib/Cargo.toml Outdated
fanninpm requested a review from youknowone April 18, 2023 15:41
youknowone requested changes Apr 18, 2023
View reviewed changes
Comment thread stdlib/src/md5.rs Outdated
youknowone reviewed Apr 18, 2023
View reviewed changes
Comment thread stdlib/src/md5.rs Outdated
youknowone requested changes Apr 18, 2023
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wow, You made it 👍
Looks mostly good. I left a few comments.

Comment thread stdlib/src/hashlib.rs Outdated
Comment thread stdlib/src/hashlib.rs Outdated
fanninpm reviewed Apr 19, 2023
View reviewed changes
Comment thread Lib/test/test_enum.py Outdated
Masorubka1 requested a review from youknowone April 20, 2023 11:42
youknowone mentioned this pull request Apr 21, 2023
Merged
youknowone requested changes Apr 21, 2023
View reviewed changes
Comment thread Lib/test/test_secrets.py Outdated
Comment thread vm/src/function/buffer.rs Outdated
Comment thread stdlib/src/hashlib.rs Outdated
youknowone force-pushed the test_hashlib.py branch 2 times, most recently from 40d9194 to 7ea4fc6 Compare April 23, 2023 06:27
youknowone approved these changes Apr 23, 2023
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! This is great, I like it very much!

youknowone merged commit 4e0890a into RustPython:main Apr 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fanninpm fanninpm left review comments
youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL