Add loongarch64 support - #4914
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Related CPython issues
ref
Sorry, something went wrong.
| machine = platform.machine() | ||
| suffix = sysconfig.get_config_var('EXT_SUFFIX') | ||
| if re.match('(aarch64|arm|mips|ppc|powerpc|s390|sparc)', machine): | ||
| if re.match('(aarch64|arm|loongarch64|mips|ppc|powerpc|s390|sparc)', machine): |
There was a problem hiding this comment.
We generally don't edit this file ourselves because it mostly came from CPython.
But I understand this is necessary to correctly support the architecture.
Not to lose the changes when we update this file to new version,
Adding a comment is useful.
| if re.match('(aarch64|arm|loongarch64|mips|ppc|powerpc|s390|sparc)', machine): | |
| # XXX: RUSTPYTHON; loongarch64 is locally added in github #4914 | |
| if re.match('(aarch64|arm|loongarch64|mips|ppc|powerpc|s390|sparc)', machine): |
And also, I found the related CPython patch doesn't include this change. Is it necessary in RustPython?
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for your careful review!
It is not necessary in RustPython.
Fixed.
Sorry, something went wrong.
youknowone
left a comment
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
|
Hi @youknowone I fixed cargo fmt and clippy issues and ran the test for Ubuntu 22.04 x86_64: cargo fmt --all -- --check cargo clippy --no-default-features --features stdlib,zlib,importlib,encodings,ssl,jit -p rustpython-common -p rustpython-compiler-core -p rustpython-compiler -p rustpython-codegen -p rustpython-parser -p rustpython-vm -p rustpython-stdlib -p rustpython-jit -p rustpython-derive -p rustpython -- -Dwarnings Please review it again! Thanks, |
Sorry, something went wrong.
| MADV_MERGEABLE, MADV_NOHUGEPAGE, MADV_REMOVE, MADV_UNMERGEABLE, | ||
| }; | ||
|
|
||
| #[allow(unused_imports)] |
There was a problem hiding this comment.
This is supposed to be used by #[pyattr]
| #[allow(unused_imports)] | |
| #[pyattr] |
Because we usually use cfg - pyattr order, placing it under cfg will be better.
Sorry, something went wrong.
There was a problem hiding this comment.
Fixed
Sorry, something went wrong.
| ) | ||
| ) | ||
| ))] | ||
| #[allow(unused_imports)] |
There was a problem hiding this comment.
| #[allow(unused_imports)] | |
| #[pyattr] |
The value has to be used by pyattr to be exposed to python side
Sorry, something went wrong.
There was a problem hiding this comment.
I got :)
Sorry, something went wrong.
|
Thank you for contributing! |
Sorry, something went wrong.
Hi,
cargo build && test, all tests pass:
Running unittests src/lib.rs (target/debug/deps/rustpython-2c061bc00c2f70a2) running 1 test Hello Hello test tests::test_run_script ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.38s Running unittests src/main.rs (target/debug/deps/rustpython-f9242e878d797bdd) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests rustpython running 1 test test src/lib.rs - (line 8) - compile ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.15sPlease review my patch.
Thanks,
Leslie Zhai