FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implemented __reduce__ method for types.SimpleNamespace by LucaSforza · Pull Request #4975 · RustPython/RustPython · GitHub

Repository navigation

Implemented __reduce__ method for types.SimpleNamespace - #4975

Merged
youknowone merged 2 commits into
RustPython:mainfrom
LucaSforza:main
May 17, 2023
Merged

youknowone merged 2 commits into
RustPython:mainfrom
LucaSforza:main

Conversation

Copy link
Copy Markdown
Contributor

Added __reduce__ method for types.SimpleNamespace #3611.

Copy link
Copy Markdown
Contributor

cc @Snowapril

Copy link
Copy Markdown
Member

Congratulation! You fixed a test test.test_types.SimpleNamespaceTests.test_pickle
Could you remove expectedFailure decorator and # TODO comment from the test?

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

youknowone merged commit a1d9c64 into RustPython:main May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL