FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

updated _collections_abc.py and test_collections.py to CPython 3.11.2 by bobby-palmer · Pull Request #5016 · RustPython/RustPython · GitHub

updated _collections_abc.py and test_collections.py to CPython 3.11.2 - #5016

Merged
DimitrisJim merged 2 commits into
RustPython:mainfrom
bobby-palmer:updated_collections_abc.py
Jun 18, 2023
Merged

updated _collections_abc.py and test_collections.py to CPython 3.11.2#5016
DimitrisJim merged 2 commits into
RustPython:mainfrom
bobby-palmer:updated_collections_abc.py

Conversation

bobby-palmer commented Jun 18, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

#4564 updating _collections_abc.py to 3.11.2 for Python

DimitrisJim commented Jun 18, 2023
edited
Loading

Copy link
Copy Markdown
Member

thanks @bobby-palmer, this might be a tricky one 😄 there's two test cases now failing in Lib/test/test_typing.py:

test_errors (test.test_typing.CollectionsCallableTests.test_errors)
test_valid_uses (test.test_typing.ParamSpecTests.test_valid_uses)

You can open that file and decorate them with unittest.expectedFailure to mark them as so. For test_errors you can add this function to CollectionsCallableTests:

    # TODO: RUSTPYTHON
    @unittest.expectedFailure
    def test_errors(self): # TODO: RUSTPYTHON, remove when this passes
        super().test_errors() # TODO: RUSTPYTHON, remove when this passes

while for test_valid_uses just mark the function directly since it isn't brought in via inheritance:

    # TODO: RUSTPYTHON
    @unittest.expectedFailure
    def test_valid_uses(self):
        ....  # function body unchanged

Copy link
Copy Markdown
Contributor Author

@DimitrisJim thanks for the feedback! those tests should be fixed now

DimitrisJim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice, guess this wasn't tricky after all. thanks!

DimitrisJim merged commit 500b002 into RustPython:main Jun 18, 2023
bobby-palmer deleted the updated_collections_abc.py branch June 18, 2023 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL