FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[VM] Object pickling implementation for product object (python itertools) by MannarAmuthan · Pull Request #5089 · RustPython/RustPython · GitHub

  1. RustPython
  2. RustPython

Repository navigation

[VM] Object pickling implementation for product object (python itertools) - #5089

Merged
youknowone merged 4 commits into
RustPython:mainfrom
MannarAmuthan:pickle-product
Oct 12, 2023
ConversationCommits (4)ChecksFiles changed
Merged

[VM] Object pickling implementation for product object (python itertools) #5089
youknowone merged 4 commits into
RustPython:mainfrom
MannarAmuthan:pickle-product

Conversation

MannarAmuthan commented Oct 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Implemented 'reduce', 'setstate' methods in product object of python itertools
  2. Uncommented expected failure annotation and ran tests

Issue:
#3611

fanninpm mentioned this pull request Oct 11, 2023
Closed
22 of 27 tasks
MannarAmuthan changed the title [VM] Pickle implementation for product object (python itertools) [VM] Object pickling implementation for product object (python itertools) Oct 11, 2023
youknowone reviewed Oct 11, 2023
View reviewed changes
Comment thread vm/src/stdlib/itertools.rs Outdated
r: AtomicCell<usize>, // Size of result tuple
exhausted: AtomicCell<bool>, // Set when the iterator is exhausted
pool: Vec<PyObjectRef>,
// Collected input iterable

youknowone Oct 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The comment place here is looking weird. Isn't this expected to be put on upper line?

MannarAmuthan Oct 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi,

Thanks for response,

Yeah, actually I am not sure how this is getting formatted (maybe because of my IDE).
Anyway will fix it and push this.

Now Ran (cargo fmt -all)

MannarAmuthan Oct 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

some tests are failing after this formatting, But I don't think, it is related to this change(formatting comments).
Is it possible to run tests again?

youknowone approved these changes Oct 12, 2023
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! The test is looking flaky

youknowone merged commit 9241e2e into RustPython:main Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL