FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Sre Engine Implementing to CPython 3.12 by qingshi163 · Pull Request #5125 · RustPython/RustPython · GitHub

/ RustPython Public

Update Sre Engine Implementing to CPython 3.12 - #5125

Merged
youknowone merged 7 commits into
RustPython:mainfrom
qingshi163:sre-dev
Mar 30, 2024
ConversationCommits (7)ChecksFiles changed
Merged

Update Sre Engine Implementing to CPython 3.12#5125
youknowone merged 7 commits into
RustPython:mainfrom
qingshi163:sre-dev

Conversation

qingshi163 commented Nov 26, 2023 •
edited by youknowone
Loading

Copy link
Copy Markdown
Contributor

youknowone commented Nov 27, 2023

Copy link
Copy Markdown
Member

@qingshi163 can sre-engine be used as an indepdendent crate out of RustPython? If not, how about putting it in this repository as rustpython-sre-engine?

qingshi163 commented Dec 3, 2023

Copy link
Copy Markdown
Contributor Author

@qingshi163 can sre-engine be used as an indepdendent crate out of RustPython? If not, how about putting it in this repository as rustpython-sre-engine?

sure

qingshi163 changed the title [WIP] Update Sre Engine Implementing to CPython 3.12 Update Sre Engine Implementing to CPython 3.12 Jan 3, 2024
qingshi163 marked this pull request as ready for review January 3, 2024 15:36
qingshi163 requested a review from youknowone January 3, 2024 15:37
youknowone reviewed Feb 10, 2024
View reviewed changes
Comment thread vm/Cargo.toml Outdated
# sre-engine = "0.4.1"
# to work on sre-engine locally or git version
# sre-engine = { git = "https://github.com/RustPython/sre-engine", rev = "refs/pull/14/head" }
sre-engine = { git = "https://github.com/RustPython/sre-engine", rev = "refs/pull/17/head" }

youknowone Feb 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am sorry to forget about this. update to recent release of sre-engine or import the source code here?

qingshi163 Feb 21, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you move the repr to rustpython-sre-engine.

youknowone Mar 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am going to import sre_engine in #5202

youknowone commented Mar 18, 2024

Copy link
Copy Markdown
Member

@qingshi163 other clippy errors looks mostly false positive or trivial. But could you check if clippy::never_loop one is intended or not?

qingshi163 commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

@qingshi163 other clippy errors looks mostly false positive or trivial. But could you check if clippy::never_loop one is intended or not?

The loop of valued break is needed for performance issue, we just need to ignore the warning

youknowone approved these changes Mar 22, 2024
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's remove unused code blocks or add a TODO note to share why they are left as commented.

Comment thread vm/src/stdlib/sre.rs Outdated
Comment thread vm/src/stdlib/sre.rs Outdated

youknowone commented Mar 30, 2024

Copy link
Copy Markdown
Member

Please revert the deletion once it is required

youknowone merged commit e349b0f into RustPython:main Mar 30, 2024
youknowone mentioned this pull request Mar 30, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL