Check value is PyType first - #5227
Merged
youknowone merged 2 commits intoApr 15, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Merged
youknowone
approved these changes
Apr 15, 2024
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request continues from #5225 PR. In that PR, I missed to downcast value to PyType type when evaluating both_module value. So cargo run -- --install-pip get-pip was still failed in the same reason.
This pull request downcasts value to PyRef<PyType> when value is module type. Also it checks value is PyType first, once.
This pull request doesn't resolve an issue, get-pip doesn't work, completely. After this pull request, it should bump Lib/shutil to Python 3.12 version's.