filter out doc strings with opt level 2 as final step to enable test_builtin.py test_compile - #5274
Merged
youknowone merged 1 commit intoApr 25, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
5 tasks
Copy link
Copy Markdown
Member
|
I am sorry for the clippy error. rebase will resolve it. |
Sorry, something went wrong.
hydrogen602
force-pushed
the
optimize=2-no-doc-strings
branch
from
0799695 to
707a905
Compare
April 25, 2024 06:21
Copy link
Copy Markdown
Contributor
Author
|
I've rebased onto the latest commit in main. Removing the doc strings turned out to be far easier than I thought, I could've bundled it with the other PR. |
Sorry, something went wrong.
youknowone
approved these changes
Apr 25, 2024
youknowone
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the last todo item of #5251
Optimize=2 removes doc strings, so I added code to do that.
The unit tests will most likely fail as the main branch commit this branch is based on doesn't pass all the tests.