FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add zoneinfo Library from Python 3.12.6 by rroblf01 · Pull Request #5400 · RustPython/RustPython · GitHub

/ RustPython Public

Add zoneinfo Library from Python 3.12.6 - #5400

Merged
youknowone merged 1 commit into
RustPython:mainfrom
rroblf01:main
Sep 19, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Add zoneinfo Library from Python 3.12.6#5400
youknowone merged 1 commit into
RustPython:mainfrom
rroblf01:main

Conversation

rroblf01 commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

In this PR I have added zoneinfo with the corresponding test suite.

youknowone requested changes Sep 17, 2024
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you so much for contributing! Just one more thing. Could you check which Python version did you brought the library from?

rroblf01 commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

Thank you so much for contributing! Just one more thing. Could you check which Python version did you brought the library from?

Good afternoon,
This library was introduced as is in 3.11, but it is compatible with 3.12 and so far with what has been developed for python 3.13.0rc2

youknowone commented Sep 18, 2024

Copy link
Copy Markdown
Member

Do you mean you copied them from 3.13.0rc2? That's for record purpose. We usually leave version information the copied version for later.

rroblf01 commented Sep 18, 2024

Copy link
Copy Markdown
Contributor Author

Do you mean you copied them from 3.13.0rc2? That's for record purpose. We usually leave version information the copied version for later.

Hello,

I prefer to say that it is taken from python 3.12.6.

rroblf01 changed the title Add zoneinfo Add zoneinfo Library from Python 3.12.6 Sep 18, 2024
youknowone merged commit b5c1fd9 into RustPython:main Sep 19, 2024

youknowone commented Sep 19, 2024

Copy link
Copy Markdown
Member

Thank you for confirming!
And welcome to the project.

youknowone mentioned this pull request Sep 19, 2024
Closed
sadboy pushed a commit to sdf-labs/RustPython that referenced this pull request Oct 14, 2024
Add zoneinfo from Python 3.12.6 (RustPython#5400)
953f60a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL