Fix _ctypes.Array base and metaclass - #5620
Merged
youknowone merged 4 commits intoMar 27, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
28 tasks
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The following causes different results in python and this branch:
from _ctypes import _SimpleCData
class c_short(_SimpleCData):
_type_ = "h"
print(c_short.__mul__(5))Python:
<class '__main__.c_short_Array_5'>
RustPython:
Traceback (most recent call last):
File "tmp.py", line 6, in <module>
print(c_short.__mul__(5))
TypeError: unexpected payload for __repr__
Note that on main the repr is simply incorrect (I haven't checked explicitly, but in previous testing, that is what I saw).
I don't think the cpython implementation PyCArrayType does anything special, so I assume this is a general rustpython compatibility.
Sorry, something went wrong.
arihant2math
approved these changes
Mar 25, 2025
Copy link
Copy Markdown
Contributor
|
That seems to no longer occur for that case, but I suppose there might have been a bug in that patch. |
Sorry, something went wrong.
coolreader18
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@arihant2math could you review this PR?