common dependency in workspace - #5624
Merged
youknowone merged 2 commits intoMar 27, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
This pull request consolidates dependency definitions by transitioning several packages to use workspace-managed dependencies. The key changes include updating multiple Cargo.toml files to remove explicit version and path specifications in favor of workspace usage, adding new dependencies consistently across the project, and aligning dependency features where applicable.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| pylib/Cargo.toml | Changed rustpython-derive to use the workspace dependency flag. |
| Cargo.toml | Added several dependencies (e.g., libffi, optional) with explicit versioning. |
| vm/Cargo.toml | Converted dependencies such as optional, unicode-casing, and unic-ucd-* to workspace. |
| vm/sre_engine/Cargo.toml | Updated optional to use workspace dependency. |
| jit/Cargo.toml | Removed redundant libffi dependency block and added workspace-managed dependency. |
| compiler/literal/Cargo.toml | Converted unic-ucd-category to workspace dependency. |
| derive-impl/Cargo.toml | Replaced version-specific proc-macro2 and quote with workspace versions. |
| compiler/core/Cargo.toml | Switched serde dependency to workspace management. |
| stdlib/Cargo.toml | Updated unicode-casing and unic-* dependencies to use workspace. |
Cargo.toml:181
- The 'optional' dependency is added with a version string here, which is inconsistent with other manifests that convert it to a workspace dependency. Consider aligning its definition to { workspace = true } if that is the intended consolidation.
optional = "0.5"
Sorry, something went wrong.
Comment thread
Cargo.toml
coolreader18
approved these changes
Mar 27, 2025
youknowone
force-pushed
the
libffi-workspace
branch
from
cb22dc3 to
ba0bb06
Compare
March 27, 2025 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.