Match statements rewrite - #5628
Merged
youknowone merged 5 commits intoApr 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
arihant2math
force-pushed
the
match
branch
3 times, most recently
from
85f38df to
11a9b4d
Compare
March 27, 2025 15:01
arihant2math
marked this pull request as ready for review
March 30, 2025 20:09
Copy link
Copy Markdown
Contributor
Author
|
Note that class and sequence matching is broken, but this is still a significant improvement over the current implementation. |
Sorry, something went wrong.
youknowone
requested changes
Apr 2, 2025
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks great in general.
@coolreader18 Could you review this PR?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@coolreader18 do you have time to review? |
Sorry, something went wrong.
youknowone
reviewed
Apr 10, 2025
Comment thread
compiler/core/src/bytecode.rs
youknowone
approved these changes
Apr 10, 2025
Copy link
Copy Markdown
Member
|
@coolreader18 I wish you could comment just will do or not do |
Sorry, something went wrong.
This was referenced Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retains all match statement functionality, but rewrites all the match statement code to reduce bugs and mirror cpython. Also, it adds support for the rest of the patterns (hopefully).
Also this re-enables the codegen tests that the ruff port disabled.
Fixes: #5628 and #5491