FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrade parts of test.support by arihant2math · Pull Request #5686 · RustPython/RustPython · GitHub

Upgrade parts of test.support - #5686

Merged
youknowone merged 1 commit into
RustPython:mainfrom
arihant2math:test_support_upgrades
Jul 14, 2025
Merged

Upgrade parts of test.support#5686
youknowone merged 1 commit into
RustPython:mainfrom
arihant2math:test_support_upgrades

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

arihant2math mentioned this pull request Apr 10, 2025
23 tasks

youknowone commented Apr 14, 2025
edited
Loading

Copy link
Copy Markdown
Member

The support patches look good overall.

They remain in pending status because they primarily add new files that aren't being used anywhere yet. This means we can't fully test them right now due to lack of usage. They might not be in a fully working state.

These patches can be merged either:

  • At the final step of updating test.support
  • When other code begins to require these files

Generally, keeping patches unmerged is not ideal since conflicts gradually increase over time and patches become outdated.
However, in this specific case, since these patches are mostly adding new files (which typically don't create merge conflicts), I believe there's an exception where keeping them unmerged temporarily offers more benefits than merging them prematurely.

youknowone merged commit 04d8d69 into RustPython:main Jul 14, 2025
arihant2math deleted the test_support_upgrades branch July 14, 2025 05:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL